Skip to content

feat(clerk-js): Enable element descriptors for active devices [SDK-859]#1994

Merged
tmilewski merged 1 commit intomainfrom
SDK-859
Nov 1, 2023
Merged

feat(clerk-js): Enable element descriptors for active devices [SDK-859]#1994
tmilewski merged 1 commit intomainfrom
SDK-859

Conversation

@tmilewski
Copy link
Copy Markdown
Member

@tmilewski tmilewski commented Nov 1, 2023

Description

Adds the following appearance keys for "Active devices":

  • cl-activeDeviceListItem
  • cl-activeDeviceListItem__current
  • cl-activeDevice
  • cl-activeDevice__current

Before

Screenshot 2023-10-31 at 5 39 36 PM

After

Screenshot 2023-10-31 at 5 39 49 PM

SDK-859

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@tmilewski tmilewski requested a review from a team November 1, 2023 00:45
@tmilewski tmilewski self-assigned this Nov 1, 2023
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 1, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 582cc91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@clerk/clerk-js Patch
@clerk/types Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/backend Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tmilewski tmilewski changed the title feat(clerk-js): Enable element descriptors & ids for active devices [SDK-859] feat(clerk-js): Enable element descriptors for active devices [SDK-859] Nov 1, 2023
desiprisg
desiprisg approved these changes Nov 1, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@desiprisg desiprisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this should be on main-v4

@tmilewski tmilewski changed the base branch from main to main-v4 November 1, 2023 01:00
panteliselef
panteliselef suggested changes Nov 1, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this PR introduces commits from v5

@LekoArts LekoArts changed the base branch from main-v4 to main November 1, 2023 08:40
@LekoArts
Copy link
Copy Markdown
Contributor

LekoArts commented Nov 1, 2023

@desiprisg No, we merge things into main by default, regardless if it needs to be backported or not

@tmilewski tmilewski enabled auto-merge November 1, 2023 13:47
@tmilewski tmilewski added this pull request to the merge queue Nov 1, 2023
@tmilewski tmilewski removed this pull request from the merge queue due to a manual request Nov 1, 2023
@tmilewski tmilewski added this pull request to the merge queue Nov 1, 2023
Merged via the queue into main with commit 78fc5ee Nov 1, 2023
@tmilewski tmilewski deleted the SDK-859 branch November 1, 2023 14:51
@clerk-cookie clerk-cookie mentioned this pull request Nov 1, 2023
Merged
tmilewski added a commit that referenced this pull request Nov 1, 2023
@tmilewski
feat(clerk-js): Enable element descriptors & ids for active devices […
efef113 
…SDK-859] (#1994)

(cherry picked from commit 78fc5ee)
@clerk-cookie clerk-cookie mentioned this pull request Nov 1, 2023
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Nov 1, 2023
@clerk-cookie @tmilewski
feat(clerk-js): Enable element descriptors & ids for active devices […
0f8aedd 
…SDK-859] (#1994) (#2010)

(cherry picked from commit 78fc5ee)

Co-authored-by: Tom Milewski <me@tm.codes>
@LekoArts LekoArts mentioned this pull request Mar 13, 2024
Merged
@LekoArts LekoArts mentioned this pull request Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@dimkl dimkl dimkl approved these changes

@nikospapcom nikospapcom nikospapcom approved these changes

@panteliselef panteliselef panteliselef approved these changes

@desiprisg desiprisg desiprisg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tmilewski tmilewski

Labels

clerk-js types

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tmilewski @LekoArts @dimkl @nikospapcom @panteliselef @desiprisg @clerk-cookie