chore(clerk-js): Replace Avatar preview in OrganizationProfileAvatarUploader with Upload Button#2014
Merged
nikospapcom merged 1 commit intomainfrom Nov 6, 2023
Conversation
🦋 Changeset detectedLatest commit: 50cdf7b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nikospapcom
force-pushed
the
nikospap/core-514-organization-avatar-in-createorganization-needs-to-be
branch
from
d144469 to
990551f
Compare
panteliselef
approved these changes
Nov 3, 2023
Contributor
panteliselef
left a comment
panteliselef
left a comment
There was a problem hiding this comment.
Great stuff, i added a few minor comments
nikospapcom
force-pushed
the
nikospap/core-514-organization-avatar-in-createorganization-needs-to-be
branch
3 times, most recently
from
127fdc0 to
1c2621f
Compare
Contributor
Author
Thanks for the review @panteliselef |
panteliselef
suggested changes
Nov 6, 2023
Contributor
panteliselef
left a comment
panteliselef
left a comment
There was a problem hiding this comment.
Just caught one minor thing, the stroke colour of the new svg we are introducting
nikospapcom
force-pushed
the
nikospap/core-514-organization-avatar-in-createorganization-needs-to-be
branch
2 times, most recently
from
76d98ab to
3dce524
Compare
…ploader with Upload Button
nikospapcom
force-pushed
the
nikospap/core-514-organization-avatar-in-createorganization-needs-to-be
branch
from
3dce524 to
50cdf7b
Compare
nikospapcom
deleted the
nikospap/core-514-organization-avatar-in-createorganization-needs-to-be
branch
This was referenced Nov 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replacing AvatarPreview in
OrganizationProfileAvatarUploaderwith upload button inCreateOrganizationFormto avoid layout shiftChecklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/choreBEFORE
Screen.Recording.2023-11-02.at.10.48.22.AM.mov
AFTER
Screen.Recording.2023-11-06.at.9.38.02.AM.mov