fix(clerk-js): Return reject(err) in factor one & two code forms#2080
Merged
nikosdouvlis merged 1 commit intomainfrom Nov 9, 2023
Merged
fix(clerk-js): Return reject(err) in factor one & two code forms#2080nikosdouvlis merged 1 commit intomainfrom
nikosdouvlis merged 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 7d4be6f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yourtallness
force-pushed
the
yourtallness/properly_return_reject_err
branch
from
00f5d6c to
7d4be6f
Compare
nikosdouvlis
approved these changes
Nov 9, 2023
Member
nikosdouvlis
left a comment
nikosdouvlis
left a comment
There was a problem hiding this comment.
Thanks for tackling this @yourtallness :)
I'll let you know once I figure out why eslint behaves differently in the two branches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Was not returning the rejection in the handler for code forms.
Thanks to @nikosdouvlis for pointing out.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore