Conversation
🦋 Changeset detectedLatest commit: 3c0ea0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
desiprisg
force-pushed
the
george/sdk-1028-password-field-not-accessible-by-keyboard
branch
from
5eb07f1 to
3c0ea0a
Compare
panteliselef
approved these changes
Dec 7, 2023
Contributor
panteliselef
left a comment
panteliselef
left a comment
There was a problem hiding this comment.
I tested it locally, and fixes the issue 🎉
anagstef
approved these changes
Dec 7, 2023
desiprisg
deleted the
george/sdk-1028-password-field-not-accessible-by-keyboard
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the instant password field was autofilled, we were showing it based on styles we were detecting, but we had no access to the value via js yet. This means we also need to make it focusable even if it does not have a value, but we have detected it has been autofilled.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore