fix(clerk-js): Use redirect_url across all auth flows#229
Merged
SokratisVidros merged 1 commit intomainfrom May 11, 2022
Merged
fix(clerk-js): Use redirect_url across all auth flows#229SokratisVidros merged 1 commit intomainfrom
SokratisVidros merged 1 commit intomainfrom
Conversation
| afterSignInUrl={signInContext.afterSignInUrl} | ||
| afterSignUpUrl={signInContext.afterSignUpUrl} | ||
| afterSignInUrl={signInContext.afterSignInUrl || signInContext.redirectUrl} | ||
| afterSignUpUrl={signInContext.afterSignUpUrl || signInContext.redirectUrl} |
Member
There was a problem hiding this comment.
❓ Can we use use the redirectUrl prop directly? Eg:
<SSOCallback
afterSignUpUrl={signUpContext.afterSignUpUrl}
afterSignInUrl={signUpContext.afterSignInUrl}
redirectUrl={signUpContext.redirectUrl}
secondFactorUrl={signUpContext.signInUrl + '#/factor-two'}
/>
Contributor
Author
There was a problem hiding this comment.
Of course we can. Thanks for suggesting it.
Teach ClerkJS to respect redirect_url upon completion of OAuth and email verification flows.
SokratisVidros
force-pushed
the
respect_redirect_url_in_email_verifications
branch
from
42809d5 to
fad7d50
Compare
nikosdouvlis
approved these changes
May 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/clerk-expo@clerk/backend-core@clerk/clerk-sdk-node@clerk/edgebuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.Teach ClerkJS to respect redirect_url upon completion of OAuth and email verification flows.