Skip to content

fix(*): Apply fixes reported before ship week#2589

Merged
dimkl merged 6 commits intomainfrom
dimkl-ship-week-feedback
Jan 16, 2024
Merged

fix(*): Apply fixes reported before ship week#2589
dimkl merged 6 commits intomainfrom
dimkl-ship-week-feedback

Conversation

@dimkl
Copy link
Copy Markdown
Contributor

@dimkl dimkl commented Jan 15, 2024

Description

Update @clerk/nextjs error messages to refer to clerkMiddleware() and deprecated authMiddleware() and fix a typo in cannotRenderSignUpComponentWhenSessionExists error message.
There was also some internal refactoring for parseError helper.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@dimkl dimkl self-assigned this Jan 15, 2024
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 15, 2024

🦋 Changeset detected

Latest commit: 7f12fff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@clerk/clerk-js Patch
@clerk/backend Patch
@clerk/nextjs Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Member

@royanger royanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errors look good.

@dimkl dimkl force-pushed the dimkl-ship-week-feedback branch from bf22fdb to 7f12fff Compare January 16, 2024 09:08
@dimkl dimkl enabled auto-merge January 16, 2024 09:09
@dimkl dimkl added this pull request to the merge queue Jan 16, 2024
Merged via the queue into main with commit 9e99eb7 Jan 16, 2024
@dimkl dimkl deleted the dimkl-ship-week-feedback branch January 16, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants