Skip to content

fix(types): Fix the appearance.baseTheme type to accept array of BaseTheme#2887

Merged
anagstef merged 1 commit intomainfrom
stefanos/sdk-1387-basetheme-type-in-typescript-is-erroring-when-adding-an
Feb 29, 2024
Merged

fix(types): Fix the appearance.baseTheme type to accept array of BaseTheme#2887
anagstef merged 1 commit intomainfrom
stefanos/sdk-1387-basetheme-type-in-typescript-is-erroring-when-adding-an

Conversation

@anagstef
Copy link
Copy Markdown
Member

Description

We already have the functionality to support an array of BaseTheme items that stack on each other. We also document examples of usage here: https://clerk.com/docs/components/customization/overview#using-a-pre-built-theme

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@anagstef anagstef self-assigned this Feb 28, 2024
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 28, 2024

🦋 Changeset detected

Latest commit: be4a596

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@clerk/types Patch
@clerk/backend Patch
@clerk/clerk-js Patch
@clerk/clerk-expo Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/chrome-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor

@desiprisg desiprisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@anagstef anagstef added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit fe356ee Feb 29, 2024
@anagstef anagstef deleted the stefanos/sdk-1387-basetheme-type-in-typescript-is-erroring-when-adding-an branch February 29, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants