Correct the HTML structure of the UI components to ensure validity#2894
Merged
Correct the HTML structure of the UI components to ensure validity#2894
Conversation
🦋 Changeset detectedLatest commit: 5cf9a2a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
anagstef
changed the title
anagstef
force-pushed
the
stefanos/sdk-1419-check-fix-invalid-html-structure
branch
from
2b7b533 to
6e566bf
Compare
anagstef
force-pushed
the
stefanos/sdk-1419-check-fix-invalid-html-structure
branch
from
5633faa to
47e56a5
Compare
anagstef
changed the title
nikosdouvlis
approved these changes
Mar 5, 2024
panteliselef
reviewed
Mar 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR alters some HTML elements to fix the validity of the HTML. This includes:
divandpelements intospan, especially the ones that are descendants of abuttonaria-controlsandaria-describedbyattributes only when there is a valid valueheightandwidthattributes from animgelement. Use CSS instead.tablist,menu,menuitem.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change