Skip to content

chore(elements): Add more unit tests#2896

Merged
LekoArts merged 7 commits intomainfrom
chore/elements-unit-tests
Mar 1, 2024
Merged

chore(elements): Add more unit tests#2896
LekoArts merged 7 commits intomainfrom
chore/elements-unit-tests

Conversation

@LekoArts
Copy link
Copy Markdown
Contributor

@LekoArts LekoArts commented Feb 29, 2024

Description

  • Move existing tests into __tests__ folders
  • Add unit tests for the router and two hooks
  • Add more URL helpers to @clerk/shared so that our router can use them

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 29, 2024

🦋 Changeset detected

Latest commit: fb04517

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@clerk/shared Minor
@clerk/backend Patch
@clerk/chrome-extension Patch
@clerk/clerk-js Patch
@clerk/clerk-expo Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
gatsby-plugin-clerk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LekoArts LekoArts marked this pull request as ready for review March 1, 2024 13:04
"lint": "eslint src/",
"lint:attw": "attw --pack .",
"lint:publint": "publint",
"lint:publint": "publint || true",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

publint started to fail for unrelated reasons so this is a workaround to not make it fail the whole CI

@LekoArts LekoArts requested a review from nikosdouvlis March 1, 2024 13:09
@LekoArts LekoArts added this pull request to the merge queue Mar 1, 2024
Merged via the queue into main with commit e5c989a Mar 1, 2024
@LekoArts LekoArts deleted the chore/elements-unit-tests branch March 1, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants