Skip to content

fix(clerk-js): Fix badge misalignment on tables list when title is empty #2908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
octoper merged 3 commits into from
Mar 1, 2024
Merged

fix(clerk-js): Fix badge misalignment on tables list when title is empty #2908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1802aa8
fix(clerk-js): Render preview title wrapper element only when it's no…
octoper Mar 1, 2024
465f2e4
chore(repo): Add Changeset
octoper Mar 1, 2024
a1c502f
chore(repo): Update green-spies-shave.md
octoper Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/green-spies-shave.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Fix badge misalignment on members list when title is empty
18 changes: 11 additions & 7 deletions packages/clerk-js/src/ui/elements/UserPreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ export const UserPreview = (props: UserPreviewProps) => {
const mainIdentifierSize =
mainIdentifierVariant || ({ xs: 'subtitle', sm: 'caption', md: 'subtitle', lg: 'h1' } as const)[size];

const previewTitle = localizedTitle || name || identifier;

return (
<Flex
elementDescriptor={descriptors.userPreview}
Expand Down Expand Up @@ -143,13 +145,15 @@ export const UserPreview = (props: UserPreviewProps) => {
variant={mainIdentifierSize}
sx={[theme => ({ display: 'flex', gap: theme.sizes.$1, alignItems: 'center' }), mainIdentifierSx]}
>
<Text
as='span'
truncate
sx={{ fontWeight: 'inherit' }}
>
{localizedTitle || name || identifier}
</Text>
{previewTitle && (
<Text
as='span'
truncate
sx={{ fontWeight: 'inherit' }}
>
{previewTitle}
</Text>
)}

{badge}
</Text>
Expand Down