fix(shared): Ensure window object existence#2913
Merged
nikosdouvlis merged 2 commits intoclerk:mainfrom Mar 1, 2024
mario-jerkovic:main
Merged
fix(shared): Ensure window object existence#2913nikosdouvlis merged 2 commits intoclerk:mainfrom mario-jerkovic:main
nikosdouvlis merged 2 commits intoclerk:mainfrom
mario-jerkovic:main
Conversation
🦋 Changeset detectedLatest commit: 4dcb11d The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LekoArts
changed the title
nikosdouvlis
approved these changes
Mar 1, 2024
Member
nikosdouvlis
left a comment
nikosdouvlis
left a comment
There was a problem hiding this comment.
@mario-jerkovic A solid report and a follow-up PR with a fix, can't ask for much more 🥇
Thank you!
nikosdouvlis
pushed a commit
that referenced
this pull request
Mar 1, 2024
* fix(shared): Ensure window object existence before accessing its properties * add changeset --------- Co-authored-by: Lennart <lekoarts@gmail.com> (cherry picked from commit 2ec9f6b)
LekoArts
added a commit
that referenced
this pull request
Mar 13, 2024
* fix(shared): Ensure window object existence before accessing its properties * add changeset --------- Co-authored-by: Lennart <lekoarts@gmail.com> (cherry picked from commit 2ec9f6b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2911
This PR addresses an issue within the shared module where the window object was being accessed before verifying its existence. This premature access caused errors in environments where window is not defined, such as server-side rendering (SSR) contexts or Node.js environments. The proposed changes ensure that the browser validity check correctly precedes any reference to window.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change