Skip to content

fix(clerk-js): Show counter of members/invitations/requests even if it is 0#2935

Merged
desiprisg merged 1 commit intomainfrom
george/sdk-1457-correctly-space-counter-with-tab-title-in-org-profile-show
Mar 5, 2024
Merged

fix(clerk-js): Show counter of members/invitations/requests even if it is 0#2935
desiprisg merged 1 commit intomainfrom
george/sdk-1457-correctly-space-counter-with-tab-title-in-org-profile-show

Conversation

@desiprisg
Copy link
Copy Markdown
Contributor

Description

Show counter of members/invitations/requests even if it is 0. Remove some unnecessary logic from the <NotificationBadge /> and fix the spacing to match designs.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 5, 2024

🦋 Changeset detected

Latest commit: 39981c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@desiprisg
Copy link
Copy Markdown
Contributor Author

!preview

@desiprisg desiprisg force-pushed the george/sdk-1457-correctly-space-counter-with-tab-title-in-org-profile-show branch from 6aaa59d to 39981c4 Compare March 5, 2024 10:56
@octoper
Copy link
Copy Markdown
Member

octoper commented Mar 5, 2024

!preview

@clerk-cookie
Copy link
Copy Markdown
Collaborator

clerk-cookie commented Mar 5, 2024

Hey @octoper, your preview is available.

Status Preview Updated (UTC)
🍪 Deployed Visit preview Mar 05, 2024 11:00 AM

@desiprisg desiprisg added this pull request to the merge queue Mar 5, 2024
Merged via the queue into main with commit e7ae9c3 Mar 5, 2024
@desiprisg desiprisg deleted the george/sdk-1457-correctly-space-counter-with-tab-title-in-org-profile-show branch March 5, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants