chore(clerk-js,types): Remove unused internal components, rename text color schemes#2956
Merged
nikosdouvlis merged 1 commit intomainfrom Mar 13, 2024
Conversation
🦋 Changeset detectedLatest commit: 985ccf3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
desiprisg
force-pushed
the
george/sdk-1322-internal-refactor-rename-text-primitive-color-schemes
branch
from
06baeb5 to
985ccf3
Compare
panteliselef
approved these changes
Mar 12, 2024
Contributor
panteliselef
left a comment
panteliselef
left a comment
There was a problem hiding this comment.
The removal of unused components looks all right.
What was the reason for renaming the colorScheme ? Do we want to align it with internal naming patterns ?
nikosdouvlis
approved these changes
Mar 13, 2024
nikosdouvlis
deleted the
george/sdk-1322-internal-refactor-rename-text-primitive-color-schemes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename the
primarycolor scheme of the Text primitive tobodyand theneutraltosecondary.Also deleted some internal components that are not used anymore. Did it in the same PR as their implementation relied on the fact that
LinkandTexthad the same color scheme names, which is no longer the case. No need to refactor something that is not used anymore.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change