fix(clerk-js): Disable emailAdress field in SignUp if fields.emailAddress.disabled is true#2990
Merged
nikosdouvlis merged 1 commit intomainfrom Mar 13, 2024
Conversation
…ress.disabled is true
nikospapcom
requested review from
anagstef,
desiprisg,
dimkl,
octoper and
panteliselef
🦋 Changeset detectedLatest commit: a1cf685 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
approved these changes
Mar 13, 2024
nikosdouvlis
deleted the
nikospap/core-1649-email-address-should-not-be-editable-if-coming-from-ticket
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this pr we are disable the
emailAdresssfield in SignUp when coming from ticket flow andfields.emailAddress.disabledis trueChecklist
npm testruns as expected.npm run buildruns as expected.Type of change
BEFORE