Skip to content

chore(clerk-js): Fix misalignment of icons in account switcher #3108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
octoper merged 2 commits into from
Apr 4, 2024
Merged

chore(clerk-js): Fix misalignment of icons in account switcher #3108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9aac9eb
chore(clerk-js): Fix misalignment of icons in account switcher
octoper Apr 3, 2024
56b2639
chore(repo): Add Changeset
octoper Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/modern-hounds-push.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Fixes an icon misalignment in account switcher.
3 changes: 3 additions & 0 deletions packages/clerk-js/src/ui/components/SignIn/SignInAccountSwitcher.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,9 @@ const _SignInAccountSwitcher = () => {
iconElementDescriptor={descriptors.accountSwitcherActionButtonIcon}
iconElementId={descriptors.accountSwitcherActionButtonIcon.setId('signOutAll')}
label={localizationKeys('signIn.accountSwitcher.action__signOutAll')}
sx={t => ({
padding: `${t.space.$2} ${t.space.$1x5}`,
})}
/>
</Card.Action>
</Card.Footer>
Expand Down
13 changes: 10 additions & 3 deletions packages/clerk-js/src/ui/components/UserButton/SessionActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import type { ActiveSessionResource } from '@clerk/types';

import type { ThemableCssProp } from '~ui/styledSystem/types';

import type { ElementDescriptor, ElementId } from '../../../ui/customizables/elementDescriptors';
import type { LocalizationKey } from '../../customizables';
import { descriptors, Flex, localizationKeys } from '../../customizables';
Expand Down Expand Up @@ -172,6 +174,7 @@ type SignOutAllActionsProps = {
iconElementDescriptor?: ElementDescriptor;
iconElementId?: ElementId;
label?: LocalizationKey;
sx?: ThemableCssProp;
};

export const SignOutAllActions = (props: SignOutAllActionsProps) => {
Expand All @@ -184,13 +187,17 @@ export const SignOutAllActions = (props: SignOutAllActionsProps) => {
iconElementDescriptor,
iconElementId,
label,
sx,
} = props;
return (
<Actions
role='menu'
sx={t => ({
padding: t.space.$2,
})}
sx={[
t => ({
padding: t.space.$2,
}),
sx,
]}
>
<Action
elementDescriptor={elementDescriptor || descriptors.userButtonPopoverActionButton}
Expand Down