Skip to content

fix(clerk-js): Correctly call __internal_navigateWithError when authenticating with passkey #3172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
panteliselef merged 2 commits into from
Apr 11, 2024
Merged

fix(clerk-js): Correctly call __internal_navigateWithError when authenticating with passkey #3172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e62a36a
fix(clerk-js): Correctly call `__internal_navigateWithError` when aut…
panteliselef Apr 11, 2024
3f8a554
chore(clerk-js): Add changeset
panteliselef Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/modern-bobcats-love.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Bug Fix: When authenticating with a passkey and user was looked out an error was thrown for accessing an undefined variable
6 changes: 3 additions & 3 deletions packages/clerk-js/src/ui/components/SignIn/shared.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ import { handleError } from '../../utils';

function useHandleAuthenticateWithPasskey(onSecondFactor: () => Promise<unknown>) {
const card = useCardState();
const { setActive } = useClerk();
// @ts-expect-error -- private method for the time being
const { setActive, __internal_navigateWithError } = useClerk();
const supportEmail = useSupportEmail();
const { navigateAfterSignIn } = useSignInContext();
const { authenticateWithPasskey } = useCoreSignIn();
Expand Down Expand Up @@ -48,8 +49,7 @@ function useHandleAuthenticateWithPasskey(onSecondFactor: () => Promise<unknown>
}

if (isUserLockedError(err)) {
// @ts-expect-error -- private method for the time being
return clerk.__internal_navigateWithError('..', err.errors[0]);
return __internal_navigateWithError('..', err.errors[0]);
}
handleError(err, [], card.setError);
}
Expand Down