Skip to content

fix(clerk-js): Respect navigateAfterCreateOrganization in <OrganizationList/>#3209

Merged
panteliselef merged 4 commits intomainfrom
elef/sdk-1632-organizationlist-aftercreateorganizationurl-never-called
Apr 17, 2024
Merged

fix(clerk-js): Respect navigateAfterCreateOrganization in <OrganizationList/>#3209
panteliselef merged 4 commits intomainfrom
elef/sdk-1632-organizationlist-aftercreateorganizationurl-never-called

Conversation

@panteliselef
Copy link
Copy Markdown
Contributor

@panteliselef panteliselef commented Apr 17, 2024

Description

We were using the wrong callback by mistake, I've added a unit test that covers this case.

We will need to backport to v4, as the report came from there

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@panteliselef panteliselef self-assigned this Apr 17, 2024
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 17, 2024

🦋 Changeset detected

Latest commit: 8d1fa5e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@panteliselef panteliselef requested a review from a team April 17, 2024 12:27
@panteliselef panteliselef enabled auto-merge (squash) April 17, 2024 12:41
@panteliselef panteliselef merged commit 3daa937 into main Apr 17, 2024
@panteliselef panteliselef deleted the elef/sdk-1632-organizationlist-aftercreateorganizationurl-never-called branch April 17, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants