chore(clerk-js): Remove experimental references to passkeys#3233
Merged
panteliselef merged 4 commits intomainfrom Apr 23, 2024
Merged
chore(clerk-js): Remove experimental references to passkeys#3233panteliselef merged 4 commits intomainfrom
panteliselef merged 4 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: ef08c93 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LekoArts
approved these changes
Apr 22, 2024
Contributor
LekoArts
left a comment
LekoArts
left a comment
There was a problem hiding this comment.
Small comment, rest LGTM
| '@clerk/types': minor | ||
| --- | ||
|
|
||
| Remove any public api that is marked as experimental or has the `__experimental_` prefix that is related to passkeys. |
Contributor
There was a problem hiding this comment.
Suggested change
| Remove any public api that is marked as experimental or has the `__experimental_` prefix that is related to passkeys. | |
| Remove experimental Passkeys APIs. This includes any API that is marked as experimental or has the `__experimental_` prefix. | |
| This prepares the Passkeys release to move further along towards a beta release and eventual stable release. |
Reads clearer to me to move the passkeys mention to the beginning
panteliselef
deleted the
elef/sdk-1579-remove-experimental-passkey-leftovers
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Each experimental public api that is dropped in this PR was already replaced with a "stable" one by #3134
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change