Merged
Conversation
🦋 Changeset detectedLatest commit: 7ef7bea The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Comment on lines
+534
to
+536
|
|
||
| telemetry?.record(eventComponentMounted('Elements_Input', props)); | ||
|
|
Contributor
There was a problem hiding this comment.
❓
- Wouldn't this fire on every re-render ?
- Seeing the implementation of
eventComponentMountedthe props you seem to be interested will be ignored.
Contributor
Author
There was a problem hiding this comment.
- Yes. feat(shared): Introduce client-side caching for telemetry events #3267 is fixing this
- Thanks! I fixed it by introducing a new helper function
Contributor
Contributor
Author
There was a problem hiding this comment.
They will probably be released around the same time so it's not blocking
9 tasks
brkalow
reviewed
Apr 29, 2024
| * @example | ||
| * telemetry.record(eventComponentMounted('SignUp', props)); | ||
| */ | ||
| export function eventComponentMounted( |
Member
There was a problem hiding this comment.
can we change this one to eventPrebuiltComponentMounted (or something similar) and expose your currently named eventComponentMountedRaw as eventComponentMounted?
9 tasks
tmilewski
approved these changes
Apr 30, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds telemetry tracking to better understand what people build with Elements. Initially we'll be able to see:
Fixes SDK-1658
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change