Skip to content

fix(clerk-js): Use default value for signIn.userData#3280

Merged
panteliselef merged 2 commits intomainfrom
elef/sdk-1693-accessing-undefined-userdata-breaks-modals-with-appearance
Apr 30, 2024
Merged

fix(clerk-js): Use default value for signIn.userData#3280
panteliselef merged 2 commits intomainfrom
elef/sdk-1693-accessing-undefined-userdata-breaks-modals-with-appearance

Conversation

@panteliselef
Copy link
Copy Markdown
Contributor

Description

Use default value for signIn.userData. This will prevent the SignIn modal from breaking when an appearance prop is used in Next.js App Router.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@panteliselef panteliselef self-assigned this Apr 29, 2024
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 29, 2024

🦋 Changeset detected

Latest commit: 02f75c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@panteliselef
Copy link
Copy Markdown
Contributor Author

!snapshot

@clerk-cookie
Copy link
Copy Markdown
Collaborator

Hey @panteliselef - the snapshot version command generated the following package versions:

Package Version
@clerk/chrome-extension 1.0.3-snapshot.va233aba
@clerk/clerk-js 5.1.2-snapshot.va233aba
@clerk/clerk-expo 1.0.3-snapshot.va233aba
gatsby-plugin-clerk 5.0.0-beta.45

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.3-snapshot.va233aba --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.1.2-snapshot.va233aba --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.0.3-snapshot.va233aba --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

Copy link
Copy Markdown
Contributor

@desiprisg desiprisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@panteliselef panteliselef enabled auto-merge (squash) April 30, 2024 09:40
@panteliselef panteliselef merged commit 4678caf into main Apr 30, 2024
@panteliselef panteliselef deleted the elef/sdk-1693-accessing-undefined-userdata-breaks-modals-with-appearance branch April 30, 2024 09:48
@clerk-cookie clerk-cookie mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants