fix(clerk-js): Fix Smart captcha on Sign Up ticket flow#3351
Merged
Conversation
🦋 Changeset detectedLatest commit: 95db5ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
reviewed
May 9, 2024
panteliselef
approved these changes
May 9, 2024
Merged
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the logic determining if the captcha should fallback to 'Invisible' if the element for the 'Smart' captcha is not found in the DOM. The widget is now selected and rendered synchronously.
Explanation:
Previously the order of the events was the following:
Smartor theInvisibleCaptcha widget.The 2nd step above runs asynchronously and sometimes loading states can remove the
#clerk-captchaelement from the DOM.After this change, we move the 2nd step to be done first and synchronously decide the widget and render it (step 1 and 3).
The addition of the captcha element on the loading card may solve our current issue. However, the change described above is a better practice for avoiding future issues.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change