feat(clerk-js,shared): Custom logger to enable logging once per session#3383
Merged
feat(clerk-js,shared): Custom logger to enable logging once per session#3383
Conversation
🦋 Changeset detectedLatest commit: 830aec4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
reviewed
May 15, 2024
LekoArts
suggested changes
May 15, 2024
Contributor
LekoArts
left a comment
LekoArts
left a comment
There was a problem hiding this comment.
If you add a new file to the shared package you'll need to adjust the https://github.com/clerk/javascript/blob/main/packages/shared/subpaths.mjs array and add logger to the files array of https://github.com/clerk/javascript/blob/main/packages/shared/package.json
brkalow
reviewed
May 22, 2024
Member
brkalow
left a comment
brkalow
left a comment
There was a problem hiding this comment.
👍 let's add a JSDoc, otherwise LGTM!
LekoArts
suggested changes
May 22, 2024
LekoArts
approved these changes
May 22, 2024
desiprisg
force-pushed
the
custom_logger
branch
2 times, most recently
from
ad7452b to
108d246
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Without:
With:
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change