feat(backend,shared,clerk-js): Support suffixed cookies [CORE-2086]#3506
Closed
feat(backend,shared,clerk-js): Support suffixed cookies [CORE-2086]#3506
Conversation
🦋 Changeset detectedLatest commit: 4b3e2e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
11 tasks
f12aaa0 to
7dcea49
Compare
7dcea49 to
50ca6e3
Compare
50ca6e3 to
6a7c065
Compare
6a7c065 to
976ae21
Compare
colinclerk
reviewed
Jun 6, 2024
0655a51 to
da8dd2b
Compare
e05b4b2 to
c6335a2
Compare
548ebc5 to
2865b88
Compare
4c7d111 to
d871f0f
Compare
d871f0f to
1192df8
Compare
# Conflicts: # integration/presets/envs.ts
# Conflicts: # .github/workflows/ci.yml
5399d0a to
32b83ca
Compare
006eaf8 to
6e91c3b
Compare
dimkl
commented
Jul 17, 2024
| fakeUsers.push(fakeUser); | ||
| await u.services.users.createBapiUser(fakeUser); | ||
|
|
||
| await u.po.signIn.goTo({ timeout: 30000 }); |
Contributor
Author
There was a problem hiding this comment.
ℹ️ We expect that in this case a handshake flow should be triggered since un-suffixed __client_uat would have a a value > 0
integration/tests/sessions/root-subdomain-prod-instances.test.ts
Outdated
Show resolved
Hide resolved
98619e3 to
04fd57d
Compare
04fd57d to
4b3e2e1
Compare
Member
|
Closing this one manually as GH is partially down - the commit is already into main |
nikosdouvlis
added a commit
that referenced
this pull request
Jul 18, 2024
Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Generate suffixed and un-suffixed
__client_uat(in dev instance),__session,__clerk_db_jwt(In dev instance) cookies from ClerkJS and support reading the either the suffixed or the un-suffixed cookies in the backend SDK using the__client_uat&__sessioncookies.New ClerkJS versions will generate both suffixed and un-suffixed cookies but the backend SDK will consume only 1 of those 2.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change