feat(types,clerk-js): Introduce BackupCodeResource and user.createBackupCode() oepration #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanioxaris
requested review from
SokratisVidros,
nikosdouvlis and
yourtallness
nikosdouvlis
approved these changes
Sep 23, 2022
| path: this.path() + '/backup_codes/', | ||
| method: 'POST', | ||
| }) | ||
| )?.response as unknown as BackupCodeJSON; |
There was a problem hiding this comment.
This is not an issue with this specific PR, but the type casting/ checking for the verifyTOTP, disableTOTP and createBackupCode is definitely brittle and since it involves network requests, the actual runtime value might be different that what we expect at this point
I did a very quick pass and I think that instead of the manual type casts, I'd rather use an assertion function to at least throw/ try to recover at that point. What do you think?
This can definitely be done in a separate PR as its not related with the changes made by Haris :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/clerk-expo@clerk/backend-core@clerk/clerk-sdk-node@clerk/edgebuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.user.createBackupCode()method, that generates a set for backup codes for a userhttps://www.notion.so/clerkdev/Introduce-new-FAPI-me-backup-codes-endpoints-31f0832bb7544d4d90ba27758cac2a54