Skip to content

fix(clerk-js): Add missing x padding to ClerkAndPagesTag#3903

Merged
octoper merged 2 commits intomainfrom
alexcarpenter/sdki-561-popovercard-footer-inline-padding-missing
Aug 5, 2024
Merged

fix(clerk-js): Add missing x padding to ClerkAndPagesTag#3903
octoper merged 2 commits intomainfrom
alexcarpenter/sdki-561-popovercard-footer-inline-padding-missing

Conversation

@alexcarpenter
Copy link
Copy Markdown
Member

@alexcarpenter alexcarpenter commented Aug 5, 2024

Description

Fixes issue where no horizontal padding was used within <UserButton /> and page urls were present.

BEFORE:

Screenshot 2024-08-05 at 12 59 44 PM Screenshot 2024-08-05 at 1 00 01 PM

AFTER:

Screenshot 2024-08-05 at 1 00 35 PM Screenshot 2024-08-05 at 1 00 20 PM

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 5, 2024

🦋 Changeset detected

Latest commit: 37d841f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/clerk-js Patch
@clerk/astro Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexcarpenter alexcarpenter requested a review from octoper August 5, 2024 17:02
Copy link
Copy Markdown
Member

@octoper octoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@octoper octoper enabled auto-merge (squash) August 5, 2024 17:04
@octoper octoper merged commit 069103c into main Aug 5, 2024
@octoper octoper deleted the alexcarpenter/sdki-561-popovercard-footer-inline-padding-missing branch August 5, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants