Conversation
🦋 Changeset detectedLatest commit: b77607f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
|
!preview |
Collaborator
|
Hey @alexcarpenter, your preview is available.
|
Member
Author
|
!preview |
alexcarpenter
changed the title
createFlexGapPropertyIosCompat user agent check
…ios-google-chrome-are-rendering
alexcarpenter
changed the title
createFlexGapPropertyIosCompat user agent checkcreateFlexGapPropertyIosCompat user agent regex check
alexcarpenter
commented
Aug 27, 2024
| // This is not needed for css grid, only for flex | ||
| // TODO: Test whether we need to make the check more generic | ||
| if (navigator?.userAgent?.match(/(iphone|ipad).+os.+13.+safari/i)) { | ||
| if (navigator?.userAgent?.match(/(iphone|ipad).+(os).*(\s13).+safari/i)) { |
Member
Author
There was a problem hiding this comment.
This was the main fix here:
- navigator?.userAgent?.match(/(iphone|ipad).+os.+13.+safari/i)
+ navigator?.userAgent?.match(/(iphone|ipad).+(os).*(\s13_).+safari/i)
alexcarpenter
commented
Aug 27, 2024
Comment on lines
+6
to
9
| '& > *:not([hidden]):not([style*="visibility: hidden"]) + *:not([hidden]):not([style*="visibility: hidden"])': { | ||
| marginLeft: dir === 'row' ? val : undefined, | ||
| marginTop: dir === 'col' ? val : undefined, | ||
| }, |
Member
Author
There was a problem hiding this comment.
This update was to improve the layout rendering for the fallback:
| BEFORE | AFTER |
|---|---|
 |
 |
brkalow
reviewed
Aug 27, 2024
brkalow
approved these changes
Aug 27, 2024
brkalow
reviewed
Aug 27, 2024
brkalow
deleted the
alexcarpenter/sdki-626-bug-ui-components-in-ios-google-chrome-are-rendering
branch
alexcarpenter
added a commit
that referenced
this pull request
Aug 28, 2024
…ex check (#4034) Co-authored-by: Bryce Kalow <bryce@clerk.dev>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where
createFlexGapPropertyIosCompatwas incorrectly detecting a chrome browser agent.Chrome user agent example:
"Mozilla/5.0 (iPhone; CPU iPhone OS 17_5 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/128.0.6613.92 Mobile/15E148 Safari/604.1"Our regex was matching the
13here128.0.6613.92iOS Chrome:
Fixes SDKI-626
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change