Skip to content

fix(clerk-js): Update existing SignUp object on SignUpContinue OAuth [backport] #4227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anagstef merged 1 commit into from
Sep 26, 2024
Merged

fix(clerk-js): Update existing SignUp object on SignUpContinue OAuth [backport] #4227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/loud-tables-rush.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
'@clerk/clerk-js': patch
---

A bug was fixed to not override the existing sign-up state on the OAuth callback.

When continuing a sign-up flow with social connections, `@clerk/clerk-js` was creating a new `SignUpResource` object, instead of patching the existing one.

This was affecting Web3 sign-up flows, since the wallet ID was being overridden on the browser redirect.
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/components/SignUp/SignUpContinue.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ function _SignUpContinue() {
<SignUpSocialButtons
enableOAuthProviders={showOauthProviders}
enableWeb3Providers={showWeb3Providers}
continueSignUp
/>
)}
<SignUpForm
Expand Down