chore(clerk-js): Allow single-character usernames in <UserProfile /> validation#4243
Conversation
🦋 Changeset detectedLatest commit: 772f2a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nikospapcom
requested review from
anagstef,
chanioxaris,
octoper and
panteliselef
|
|
||
| const canSubmit = | ||
| (isUsernameRequired ? usernameField.value.length > 1 : true) && user.username !== usernameField.value; | ||
| const canSubmit = user.username !== usernameField.value; |
There was a problem hiding this comment.
❓ It seems like we have the userSettings available and thus the username min and max length. Is it possible to use them on the client side validation in place of the hardcoded value?
There was a problem hiding this comment.
We have it but we rely only on the backend validation if we have username as missing field during sign-up.
I removed the client side validation in order to have consistency and have the same behaviour in both cases
ss from missing fields screen
There was a problem hiding this comment.
@nikospapcom I don't see why this change improves things.
Currently we want to disable the button, and don't let you submit if you don't have a value in the field or the value that you matches your current username.
There was a problem hiding this comment.
Maybe only changing usernameField.value.length > 0 is enough ?
|
|
||
| const canSubmit = | ||
| (isUsernameRequired ? usernameField.value.length > 1 : true) && user.username !== usernameField.value; | ||
| const canSubmit = user.username !== usernameField.value; |
There was a problem hiding this comment.
@nikospapcom I don't see why this change improves things.
Currently we want to disable the button, and don't let you submit if you don't have a value in the field or the value that you matches your current username.
nikospapcom
force-pushed
the
nikospap/user-718-userprofile-doesnt-respect-username-settings
branch
from
670d0c5 to
772f2a4
Compare
nikospapcom
changed the title
<UserProfile /> username field<UserProfile /> validation
nikospapcom
deleted the
nikospap/user-718-userprofile-doesnt-respect-username-settings
branch
6 participants
Description
In this pr we are allowing single-character usernames in
<UserProfile />validationChecklist
npm testruns as expected.npm run buildruns as expected.Type of change