feat(clerk-js): Legal consent #4337

octoper · 2024-10-15T16:41:41Z

Description

This PR adds legal consent as an experimental feature and also updates the <SignUp/> component to display the legal consent checkbox when the legal consent requirements are enabled.

Here are some screenshots of how the<SignUp/> will look like:

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-10-15T16:41:46Z

🦋 Changeset detected

Latest commit: 248b505

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@clerk/localizations	Minor
@clerk/clerk-js	Minor
@clerk/types	Minor
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/astro	Patch
@clerk/backend	Patch
@clerk/elements	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/nextjs	Patch
@clerk/clerk-react	Patch
@clerk/remix	Patch
@clerk/clerk-sdk-node	Patch
@clerk/shared	Patch
@clerk/tanstack-start	Patch
@clerk/testing	Patch
@clerk/themes	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/clerk-js/src/ui/elements/Form.tsx

octoper · 2024-10-17T18:49:02Z

!snapshot

clerk-cookie · 2024-10-17T18:52:59Z

Hey @octoper - the snapshot version command generated the following package versions:

Package	Version
@clerk/astro	1.3.17-snapshot.vac4eebb
@clerk/backend	1.14.2-snapshot.vac4eebb
@clerk/chrome-extension	1.3.21-snapshot.vac4eebb
@clerk/clerk-js	5.28.0-snapshot.vac4eebb
@clerk/elements	0.16.3-snapshot.vac4eebb
@clerk/clerk-expo	2.2.27-snapshot.vac4eebb
@clerk/express	1.3.2-snapshot.vac4eebb
@clerk/fastify	2.0.4-snapshot.vac4eebb
@clerk/localizations	3.4.0-snapshot.vac4eebb
@clerk/nextjs	5.7.6-snapshot.vac4eebb
@clerk/clerk-react	5.12.1-snapshot.vac4eebb
@clerk/remix	4.2.40-snapshot.vac4eebb
@clerk/clerk-sdk-node	5.0.53-snapshot.vac4eebb
@clerk/shared	2.9.3-snapshot.vac4eebb
@clerk/tanstack-start	0.4.16-snapshot.vac4eebb
@clerk/testing	1.3.14-snapshot.vac4eebb
@clerk/themes	2.1.38-snapshot.vac4eebb
@clerk/types	4.27.0-snapshot.vac4eebb

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@1.3.17-snapshot.vac4eebb --save-exact

@clerk/backend

npm i @clerk/backend@1.14.2-snapshot.vac4eebb --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.3.21-snapshot.vac4eebb --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.28.0-snapshot.vac4eebb --save-exact

@clerk/elements

npm i @clerk/elements@0.16.3-snapshot.vac4eebb --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.2.27-snapshot.vac4eebb --save-exact

@clerk/express

npm i @clerk/express@1.3.2-snapshot.vac4eebb --save-exact

@clerk/fastify

npm i @clerk/fastify@2.0.4-snapshot.vac4eebb --save-exact

@clerk/localizations

npm i @clerk/localizations@3.4.0-snapshot.vac4eebb --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.7.6-snapshot.vac4eebb --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.12.1-snapshot.vac4eebb --save-exact

@clerk/remix

npm i @clerk/remix@4.2.40-snapshot.vac4eebb --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.53-snapshot.vac4eebb --save-exact

@clerk/shared

npm i @clerk/shared@2.9.3-snapshot.vac4eebb --save-exact

@clerk/tanstack-start

npm i @clerk/tanstack-start@0.4.16-snapshot.vac4eebb --save-exact

@clerk/testing

npm i @clerk/testing@1.3.14-snapshot.vac4eebb --save-exact

@clerk/themes

npm i @clerk/themes@2.1.38-snapshot.vac4eebb --save-exact

@clerk/types

npm i @clerk/types@4.27.0-snapshot.vac4eebb --save-exact

packages/clerk-js/src/ui/components/SignUp/SignUpContinue.tsx

packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx

packages/types/src/signUp.ts

packages/clerk-js/src/core/clerk.ts

octoper · 2024-10-18T12:16:28Z

!snapshot

clerk-cookie · 2024-10-18T12:20:53Z

Hey @octoper - the snapshot version command generated the following package versions:

Package	Version
@clerk/astro	1.3.17-snapshot.v067db9b
@clerk/backend	1.14.2-snapshot.v067db9b
@clerk/chrome-extension	1.3.21-snapshot.v067db9b
@clerk/clerk-js	5.28.0-snapshot.v067db9b
@clerk/elements	0.17.0-snapshot.v067db9b
@clerk/clerk-expo	2.2.27-snapshot.v067db9b
@clerk/express	1.3.2-snapshot.v067db9b
@clerk/fastify	2.0.4-snapshot.v067db9b
@clerk/localizations	3.4.0-snapshot.v067db9b
@clerk/nextjs	5.8.0-snapshot.v067db9b
@clerk/clerk-react	5.12.1-snapshot.v067db9b
@clerk/remix	4.2.40-snapshot.v067db9b
@clerk/clerk-sdk-node	5.0.53-snapshot.v067db9b
@clerk/shared	2.10.0-snapshot.v067db9b
@clerk/tanstack-start	0.4.16-snapshot.v067db9b
@clerk/testing	1.3.14-snapshot.v067db9b
@clerk/themes	2.1.38-snapshot.v067db9b
@clerk/types	4.27.0-snapshot.v067db9b

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@1.3.17-snapshot.v067db9b --save-exact

@clerk/backend

npm i @clerk/backend@1.14.2-snapshot.v067db9b --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.3.21-snapshot.v067db9b --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.28.0-snapshot.v067db9b --save-exact

@clerk/elements

npm i @clerk/elements@0.17.0-snapshot.v067db9b --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.2.27-snapshot.v067db9b --save-exact

@clerk/express

npm i @clerk/express@1.3.2-snapshot.v067db9b --save-exact

@clerk/fastify

npm i @clerk/fastify@2.0.4-snapshot.v067db9b --save-exact

@clerk/localizations

npm i @clerk/localizations@3.4.0-snapshot.v067db9b --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.8.0-snapshot.v067db9b --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.12.1-snapshot.v067db9b --save-exact

@clerk/remix

npm i @clerk/remix@4.2.40-snapshot.v067db9b --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.53-snapshot.v067db9b --save-exact

@clerk/shared

npm i @clerk/shared@2.10.0-snapshot.v067db9b --save-exact

@clerk/tanstack-start

npm i @clerk/tanstack-start@0.4.16-snapshot.v067db9b --save-exact

@clerk/testing

npm i @clerk/testing@1.3.14-snapshot.v067db9b --save-exact

@clerk/themes

npm i @clerk/themes@2.1.38-snapshot.v067db9b --save-exact

@clerk/types

npm i @clerk/types@4.27.0-snapshot.v067db9b --save-exact

packages/clerk-js/src/ui/localization/localizationModifiers.ts

packages/clerk-js/src/ui/elements/LegalConsentCheckbox.tsx

nikospapcom · 2024-10-21T08:53:20Z

!snapshot

…able release

…ined

octoper changed the title ~~Vaggelis/user 742 add legal consent to clerk js~~ feat(clerk-js): Legal consent Oct 15, 2024

octoper self-assigned this Oct 15, 2024

clerk-cookie added types clerk-js localizations labels Oct 15, 2024

octoper force-pushed the vaggelis/user-742-add-legal-consent-to-clerk-js branch 2 times, most recently from 226bdd7 to cc75032 Compare October 16, 2024 18:22

alexcarpenter reviewed Oct 16, 2024

View reviewed changes

packages/clerk-js/src/ui/elements/Form.tsx Outdated Show resolved Hide resolved

octoper force-pushed the vaggelis/user-742-add-legal-consent-to-clerk-js branch 2 times, most recently from 4189a77 to ac4eebb Compare October 17, 2024 17:37

octoper marked this pull request as ready for review October 17, 2024 18:26

nikospapcom reviewed Oct 18, 2024

View reviewed changes

packages/clerk-js/src/ui/components/SignUp/SignUpContinue.tsx Outdated Show resolved Hide resolved

nikospapcom reviewed Oct 18, 2024

View reviewed changes

packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx Outdated Show resolved Hide resolved

panteliselef approved these changes Oct 18, 2024

View reviewed changes

packages/types/src/signUp.ts Show resolved Hide resolved

packages/clerk-js/src/core/clerk.ts Show resolved Hide resolved

octoper requested review from alexcarpenter, nikospapcom and panteliselef October 18, 2024 11:21

anagstef reviewed Oct 18, 2024

View reviewed changes

packages/clerk-js/src/ui/localization/localizationModifiers.ts Show resolved Hide resolved

alexcarpenter reviewed Oct 18, 2024

View reviewed changes

packages/clerk-js/src/ui/elements/LegalConsentCheckbox.tsx Show resolved Hide resolved

octoper force-pushed the vaggelis/user-742-add-legal-consent-to-clerk-js branch from 067db9b to 1253fa4 Compare October 18, 2024 14:40

octoper requested a review from chanioxaris October 18, 2024 16:00

octoper force-pushed the vaggelis/user-742-add-legal-consent-to-clerk-js branch from 5b15715 to 0dd7e0e Compare October 18, 2024 16:34

octoper requested a review from a team October 18, 2024 17:36

octoper force-pushed the vaggelis/user-742-add-legal-consent-to-clerk-js branch from 0dd7e0e to 9bddc6f Compare October 18, 2024 17:49

octoper added 25 commits October 23, 2024 09:59

feat(clerk-js): Handle legal consent in <SignUp/>

f5bff6e

fix(clerk-js): Fix types for SignUpCreateParams

3a4acbc

fix(clerk-js): Rename legalAccepted to __experimental_legalAccepted

cca62a9

Update sign up form

0de78e2

feat(clerk-js): Add legal consent checkbox to SignUp

5ff22b3

chore(clerk-js): Make legal accepted as experimental

79ec2ae

chore(repo): Add changeset

857dfca

chore(clerk-js): Remove localization modifiers

921d9b5

chore(clerk-js): Style the polished checkbox

bc61071

chore(clerk-js): Fix styling

11d6e6b

chore(clerk-js): Add TODO comments to remind me to do action after st…

e0038e5

…able release

test(clerk-js): Add simple tests

9ffd367

fix(clerk-js): Check missingFields is not null

163fd5d

fix(clerk-js): Fix tests

1e02572

fix(clerk-js): Fix styling for checkbox

016fee1

chore(clerk-js): Move Legal consent checkbox to its own component

d3e4c7b

chore(clerk-js): Apply lint fixes

0bc578c

fix(clerk-js,types,localization): Mark legal consent as experimental

b731ad0

fix(clerk-js): Check if the __experimental_legalAccepted is not undef…

fe370c1

…ined

tests(clerk-js): Revert changes for SignUpStart

9b1e072

tests(clerk-js): Fix SignUpContinue tests

a75f7fd

chore(clerk-js): Remove label from form control

a71579b

chore(clerk-js,types,localization): Introduce LinkRenderer

cfed76e

test(clerk-js): Update tests fixture

94247d1

fix(clerk-js): Increase bundlewatch limit for ui-common

248b505

octoper force-pushed the vaggelis/user-742-add-legal-consent-to-clerk-js branch from 669c703 to 248b505 Compare October 23, 2024 13:59

octoper merged commit 3fdcdbf into main Oct 23, 2024
21 checks passed

octoper deleted the vaggelis/user-742-add-legal-consent-to-clerk-js branch October 23, 2024 14:20

clerk-cookie mentioned this pull request Oct 23, 2024

ci(repo): Version packages #4390

Merged

wobsoriano pushed a commit that referenced this pull request Feb 8, 2025

feat(clerk-js): Legal consent (#4337)

be7dee3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(clerk-js): Legal consent #4337

feat(clerk-js): Legal consent #4337

Uh oh!

octoper commented Oct 15, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Oct 15, 2024 •

edited

Loading

Uh oh!

Uh oh!

octoper commented Oct 17, 2024

Uh oh!

clerk-cookie commented Oct 17, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

octoper commented Oct 18, 2024

Uh oh!

clerk-cookie commented Oct 18, 2024

Uh oh!

Uh oh!

Uh oh!

nikospapcom commented Oct 21, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

feat(clerk-js): Legal consent #4337

feat(clerk-js): Legal consent #4337

Uh oh!

Conversation

octoper commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

changeset-bot bot commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

octoper commented Oct 17, 2024

Uh oh!

clerk-cookie commented Oct 17, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

octoper commented Oct 18, 2024

Uh oh!

clerk-cookie commented Oct 18, 2024

Uh oh!

Uh oh!

Uh oh!

nikospapcom commented Oct 21, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

octoper commented Oct 15, 2024 •

edited

Loading

changeset-bot bot commented Oct 15, 2024 •

edited

Loading