-
Notifications
You must be signed in to change notification settings - Fork 403
feat(clerk-js,nextjs,clerk-react,types): Introduce <Waitlist /> component
#4376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 0b8ba3d The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
<Waitlist /> component
<Waitlist /> component<Waitlist /> component
73186ec to
40923a6
Compare
39d608b to
fb7aedf
Compare
packages/clerk-js/src/core/resources/__tests__/Waitlist.test.ts
Outdated
Show resolved
Hide resolved
packages/clerk-js/src/core/resources/__tests__/Waitlist.test.ts
Outdated
Show resolved
Hide resolved
packages/clerk-js/src/core/resources/__tests__/Waitlist.test.ts
Outdated
Show resolved
Hide resolved
| unmountWaitlist = (node: HTMLDivElement): void => { | ||
| if (this.clerkjs && this.#loaded) { | ||
| this.clerkjs.unmountWaitlist(node); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Are we missing a this.premountWaitlistNodes.delete(node); here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch Pantelis 🙏
0937e66 to
1313825
Compare
0e465b3 to
e498412
Compare
|
!snapshot |
|
Hey @nikospapcom - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/astro@1.4.3-snapshot.ve498412ac8617eb535cbbeb78d27ded11ad8f45c --save-exact
npm i @clerk/backend@1.15.3-snapshot.ve498412ac8617eb535cbbeb78d27ded11ad8f45c --save-exact
npm i @clerk/chrome-extension@1.3.25-snapshot.ve498412ac8617eb535cbbeb78d27ded11ad8f45c --save-exact
npm i @clerk/clerk-js@5.31.0-snapshot.ve498412ac8617eb535cbbeb78d27ded11ad8f45c --save-exact
npm i @clerk/elements@0.18.1-snapshot.ve498412ac8617eb535cbbeb78d27ded11ad8f45c --save-exact
npm i @clerk/clerk-expo@2.2.31-snapshot.ve498412ac8617eb535cbbeb78d27ded11ad8f45c --save-exact
npm i @clerk/expo-passkeys@1.0.0-snapshot.ve498412ac8617eb535cbbeb78d27ded11ad8f45c --save-exact
npm i @clerk/express@1.3.5-snapshot.ve498412ac8617eb535cbbeb78d27ded11ad8f45c --save-exact
npm i @clerk/fastify@2.0.7-snapshot.ve498412ac8617eb535cbbeb78d27ded11ad8f45c --save-exact
npm i @clerk/localizations@3.5.0-snapshot.ve498412ac8617eb535cbbeb78d27ded11ad8f45c --save-exact
npm i @clerk/nextjs@6.2.0-snapshot.ve498412ac8617eb535cbbeb78d27ded11ad8f45c --save-exact
npm i @clerk/clerk-react@5.15.0-snapshot.ve498412ac8617eb535cbbeb78d27ded11ad8f45c --save-exact
npm i @clerk/remix@4.2.43-snapshot.ve498412ac8617eb535cbbeb78d27ded11ad8f45c --save-exact
npm i @clerk/clerk-sdk-node@5.0.56-snapshot.ve498412ac8617eb535cbbeb78d27ded11ad8f45c --save-exact
npm i @clerk/shared@2.11.1-snapshot.ve498412ac8617eb535cbbeb78d27ded11ad8f45c --save-exact
npm i @clerk/tanstack-start@0.4.19-snapshot.ve498412ac8617eb535cbbeb78d27ded11ad8f45c --save-exact
npm i @clerk/testing@1.3.17-snapshot.ve498412ac8617eb535cbbeb78d27ded11ad8f45c --save-exact
npm i @clerk/themes@2.1.41-snapshot.ve498412ac8617eb535cbbeb78d27ded11ad8f45c --save-exact
npm i @clerk/types@4.30.0-snapshot.ve498412ac8617eb535cbbeb78d27ded11ad8f45c --save-exact
npm i @clerk/ui@0.1.12-snapshot.ve498412ac8617eb535cbbeb78d27ded11ad8f45c --save-exact |
2b678bd to
06fd2b2
Compare
06fd2b2 to
0b8ba3d
Compare
|
One thing I just noticed about Astro: there's now a |
Hey @mlafeldt |
Hey @mlafeldt |
|
@nikospapcom That's awesome, will give it a try! 🙏🏻 |
|
@nikospapcom Added a waitlist to my Astro app without a hitch. 💥 Left some feedback here. |
Description
Show
Join waitlistpromt from<SignIn />component when mode iswaitlistChange the text in
RestrictedAccesscomponent when mode iswaitlistIntroduce
<Waitlist />component to allow users to join in the waitlist via emailIntroduce
joinWaitlistmethod inclerkclassIntroduce
redirectToWaitlistfunction inclerkclass to allow user to redirect to waitlist pageChecklist
npm testruns as expected.npm run buildruns as expected.Type of change
<SignIn />Component withsign_up.mode = waitlist<SignUp />Component withsign_up.mode = waitlist<Waitlist />Component<Waitlist />Component success screen<Waitlist />Component success screen withredirectUrlpresented