feat(elements): Support SignIn.Captcha and sso-callback step #4523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3f5b954 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brkalow
commented
Nov 8, 2024
Comment on lines
-81
to
-84
| signInForceRedirectUrl: ClerkJSNavigationEvent.complete, | ||
| signInFallbackRedirectUrl: ClerkJSNavigationEvent.complete, | ||
| signUpForceRedirectUrl: ClerkJSNavigationEvent.complete, | ||
| signUpFallbackRedirectUrl: ClerkJSNavigationEvent.complete, |
Member
Author
There was a problem hiding this comment.
Now that we're not passing beforeEmit to setActive internally, our custom navigate hackery wasn't working as intended here. Removing the URLs allows navigate to complete.
Member
There was a problem hiding this comment.
Does this mean we broke the usage of handleRedirectCallback for everyone ?
There was a problem hiding this comment.
Hey, trying to use <SignIn.Captcha /> but I see Property 'Captcha' does not exist ....
I believe you forgot to export this component in index.ts right?
panteliselef
approved these changes
Nov 8, 2024
alexcarpenter
approved these changes
Nov 8, 2024
9 tasks
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces support for
<SignIn.Captcha>as well as<SignIn.Step name='sso-callback'>. This allows rendering of the CAPTCHA widget when a sign in flow is transferred to a sign up flow.Also fixes a bug with the SSO callback where a successful auth would navigate to the incorrect URL. This was due to a recent change that switched to passing a URL directly to
setActive(), instead ofbeforeEmit.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change