-
Notifications
You must be signed in to change notification settings - Fork 402
fix(clerk-js): No TokenUpdate side-effect on new Session()
#4555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: e1e8fc4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
new Session()new Session()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
!snapshot |
1 similar comment
|
!snapshot |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Description
Currently, initialization of a
Sessionresource has a side-effect of emitting aTokenUpdateevent. This is problematic for a few reasons:clerk.organization"accessor" being available, which is set after the client object is fetched and initializedI believe the intent here is to ensure the session cookie is fresh immediately on load of Clerk, and so I've moved this behavior to explicitly live in the Clerk loading flow.
fixes SDKI-765
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change