feat(clerk-js): Add allowedRedirectProtocols #4705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dce268f The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alexcarpenter
approved these changes
Dec 3, 2024
panteliselef
approved these changes
Dec 3, 2024
Comment on lines
+17
to
+18
| * Note that this utility should **never** be called with a user-provided URL. We make no specific checks against the contents of the URL here and assume it is safe. Use `Clerk.navigate()` instead for user-provided URLs. | ||
| */ |
Member
There was a problem hiding this comment.
Should we replace the usage for windowNavigate from SignIn.ts and SignUp.ts with Clerk.navigate() ?
Member
Author
There was a problem hiding this comment.
I don't think we need to, as the url is provided from our API and it will always be external.
4 tasks
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce a new Clerk option,
allowedRedirectProtocolsthat allows users to specify custom protocols to be allowed as part of user-provided redirect URLs. This is necessary for cases where deep-linking is used, in an Electron app for example.As part of this, I've removed the protocol check from
windowNavigate. This is an internal method that is used in only a few places, none of which should be accepting arbitrary, user-provided URLs. I've also added a JSDoc comment indicatingwindowNavigateshould never be used when accepting user-provided URLs.fixes SDKI-782
Closes: #4667
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change