Skip to content

Conversation

@kostaspt
Copy link
Member

@kostaspt kostaspt commented Dec 12, 2024

Description

createAllowedRedirectOrigins now takes the instance type into account to include the Frontend API URL for development instances.

This came up while releasing the new version of Clerk as an IdP, which requires a redirect to {frontendApi}/oauth/authorize. For local development, this previously had to be manually added to the allowed origins. Since it's a safe URL to include by default, it makes sense to add it everytime for development instances.

Fixes: SDK-2033

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2024

🦋 Changeset detected

Latest commit: 42cd798

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 1:47pm

@kostaspt
Copy link
Member Author

!snapshot

@kostaspt kostaspt force-pushed the kostas/add-oidc-endpoint-to-allowed branch from 9a085ba to 51eaec6 Compare December 12, 2024 14:10
@kostaspt kostaspt changed the title feat: Add OAuth authorize URL to allowed redirect origins feat(clerk-js): Add OAuth URL to allowed redirect origins Dec 12, 2024
@clerk-cookie
Copy link
Collaborator

Hey @kostaspt - the snapshot version command generated the following package versions:

Package Version
@clerk/astro 2.1.1-snapshot.v20241212141113
@clerk/backend 1.21.1-snapshot.v20241212141113
@clerk/chrome-extension 2.1.1-snapshot.v20241212141113
@clerk/clerk-js 5.42.0-snapshot.v20241212141113
@clerk/elements 0.22.1-snapshot.v20241212141113
@clerk/clerk-expo 2.5.1-snapshot.v20241212141113
@clerk/expo-passkeys 0.1.1-snapshot.v20241212141113
@clerk/express 1.3.28-snapshot.v20241212141113
@clerk/fastify 2.1.1-snapshot.v20241212141113
@clerk/localizations 3.9.1-snapshot.v20241212141113
@clerk/nextjs 6.9.1-snapshot.v20241212141113
@clerk/nuxt 0.1.1-snapshot.v20241212141113
@clerk/clerk-react 5.20.1-snapshot.v20241212141113
@clerk/react-router 0.1.1-snapshot.v20241212141113
@clerk/remix 4.4.1-snapshot.v20241212141113
@clerk/clerk-sdk-node 5.1.1-snapshot.v20241212141113
@clerk/shared 2.20.1-snapshot.v20241212141113
@clerk/tanstack-start 0.8.1-snapshot.v20241212141113
@clerk/testing 1.4.1-snapshot.v20241212141113
@clerk/themes 2.2.1-snapshot.v20241212141113
@clerk/types 4.39.3-snapshot.v20241212141113
@clerk/ui 0.3.1-snapshot.v20241212141113
@clerk/vue 0.1.1-snapshot.v20241212141113

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@2.1.1-snapshot.v20241212141113 --save-exact

@clerk/backend

npm i @clerk/backend@1.21.1-snapshot.v20241212141113 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@2.1.1-snapshot.v20241212141113 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.42.0-snapshot.v20241212141113 --save-exact

@clerk/elements

npm i @clerk/elements@0.22.1-snapshot.v20241212141113 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.5.1-snapshot.v20241212141113 --save-exact

@clerk/expo-passkeys

npm i @clerk/expo-passkeys@0.1.1-snapshot.v20241212141113 --save-exact

@clerk/express

npm i @clerk/express@1.3.28-snapshot.v20241212141113 --save-exact

@clerk/fastify

npm i @clerk/fastify@2.1.1-snapshot.v20241212141113 --save-exact

@clerk/localizations

npm i @clerk/localizations@3.9.1-snapshot.v20241212141113 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@6.9.1-snapshot.v20241212141113 --save-exact

@clerk/nuxt

npm i @clerk/nuxt@0.1.1-snapshot.v20241212141113 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.20.1-snapshot.v20241212141113 --save-exact

@clerk/react-router

npm i @clerk/react-router@0.1.1-snapshot.v20241212141113 --save-exact

@clerk/remix

npm i @clerk/remix@4.4.1-snapshot.v20241212141113 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.1.1-snapshot.v20241212141113 --save-exact

@clerk/shared

npm i @clerk/shared@2.20.1-snapshot.v20241212141113 --save-exact

@clerk/tanstack-start

npm i @clerk/tanstack-start@0.8.1-snapshot.v20241212141113 --save-exact

@clerk/testing

npm i @clerk/testing@1.4.1-snapshot.v20241212141113 --save-exact

@clerk/themes

npm i @clerk/themes@2.2.1-snapshot.v20241212141113 --save-exact

@clerk/types

npm i @clerk/types@4.39.3-snapshot.v20241212141113 --save-exact

@clerk/ui

npm i @clerk/ui@0.3.1-snapshot.v20241212141113 --save-exact

@clerk/vue

npm i @clerk/vue@0.1.1-snapshot.v20241212141113 --save-exact

@clerk-cookie
Copy link
Collaborator

Hello 👋

We currently close PRs after 60 days of inactivity. It's been 50 days since the last update here. If we missed this PR, please reply here. Otherwise, we'll close this PR in 10 days.

Thanks for being a part of the Clerk community! 🙏

@kostaspt kostaspt force-pushed the kostas/add-oidc-endpoint-to-allowed branch from 5a69ed2 to b28f9c3 Compare February 5, 2025 10:50
@kostaspt kostaspt changed the title feat(clerk-js): Add OAuth URL to allowed redirect origins feat(clerk-js): Add Frontend API URL to allowed redirect origins Feb 5, 2025
@kostaspt
Copy link
Member Author

kostaspt commented Feb 5, 2025

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @kostaspt - the snapshot version command generated the following package versions:

Package Version
@clerk/chrome-extension 2.2.7-snapshot.v20250205111539
@clerk/clerk-js 5.52.1-snapshot.v20250205111539
@clerk/clerk-expo 2.7.5-snapshot.v20250205111539

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@2.2.7-snapshot.v20250205111539 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.52.1-snapshot.v20250205111539 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.7.5-snapshot.v20250205111539 --save-exact

@kostaspt kostaspt marked this pull request as ready for review February 5, 2025 13:27
@kostaspt kostaspt force-pushed the kostas/add-oidc-endpoint-to-allowed branch from b28f9c3 to 42cd798 Compare February 5, 2025 13:46
@clerk-cookie clerk-cookie removed the Stale label Feb 6, 2025
@kostaspt kostaspt merged commit f936cf1 into main Feb 6, 2025
29 checks passed
@kostaspt kostaspt deleted the kostas/add-oidc-endpoint-to-allowed branch February 6, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants