Skip to content

Conversation

@LauraBeatris
Copy link
Member

@LauraBeatris LauraBeatris commented Jan 16, 2025

Description

Allows to use enterprise_sso for custom flows with @clerk/elements

<Clerk.Connection name="enterprise_sso">Sign in with SSO</Clerk.Connection>

<Clerk.Field name="identifier">
    <Clerk.Label>Email Address</Clerk.Label>
    <Clerk.Input type="text" required />
</Clerk.Field>
CleanShot.2025-01-16.at.18.42.48.mp4

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@LauraBeatris LauraBeatris self-assigned this Jan 16, 2025
@changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2025

🦋 Changeset detected

Latest commit: 941a14a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@clerk/elements Patch
@clerk/types Patch
@clerk/ui Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/clerk-js Patch
@clerk/expo-passkeys Patch
@clerk/clerk-expo Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/shared Patch
@clerk/tanstack-start Patch
@clerk/testing Patch
@clerk/themes Patch
@clerk/vue Patch
@clerk/chrome-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 10:38pm

@LauraBeatris LauraBeatris force-pushed the laura/orgs-480-support-enterprise_sso-strategy-on-clerkelements branch 3 times, most recently from 173de41 to 1e1014e Compare January 16, 2025 21:20
@LauraBeatris
Copy link
Member Author

!snapshot

@LauraBeatris LauraBeatris force-pushed the laura/orgs-480-support-enterprise_sso-strategy-on-clerkelements branch from 1e1014e to 413fe0d Compare January 16, 2025 21:22
@LauraBeatris LauraBeatris force-pushed the laura/orgs-480-support-enterprise_sso-strategy-on-clerkelements branch from 413fe0d to 7cc0576 Compare January 16, 2025 21:24
@clerk-cookie
Copy link
Collaborator

Hey @LauraBeatris - the snapshot version command generated the following package versions:

Package Version
@clerk/astro 2.1.10-snapshot.v20250116212318
@clerk/backend 1.23.2-snapshot.v20250116212318
@clerk/chrome-extension 2.1.14-snapshot.v20250116212318
@clerk/clerk-js 5.45.1-snapshot.v20250116212318
@clerk/elements 0.22.10-snapshot.v20250116212318
@clerk/clerk-expo 2.6.13-snapshot.v20250116212318
@clerk/expo-passkeys 0.1.9-snapshot.v20250116212318
@clerk/express 1.3.37-snapshot.v20250116212318
@clerk/fastify 2.1.10-snapshot.v20250116212318
@clerk/localizations 3.9.10-snapshot.v20250116212318
@clerk/nextjs 6.9.13-snapshot.v20250116212318
@clerk/nuxt 1.0.6-snapshot.v20250116212318
@clerk/clerk-react 5.22.1-snapshot.v20250116212318
@clerk/react-router 0.1.11-snapshot.v20250116212318
@clerk/remix 4.4.12-snapshot.v20250116212318
@clerk/shared 2.20.9-snapshot.v20250116212318
@clerk/tanstack-start 0.8.11-snapshot.v20250116212318
@clerk/testing 1.4.10-snapshot.v20250116212318
@clerk/themes 2.2.8-snapshot.v20250116212318
@clerk/types 4.41.1-snapshot.v20250116212318
@clerk/ui 0.3.11-snapshot.v20250116212318
@clerk/vue 1.1.1-snapshot.v20250116212318

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@2.1.10-snapshot.v20250116212318 --save-exact

@clerk/backend

npm i @clerk/backend@1.23.2-snapshot.v20250116212318 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@2.1.14-snapshot.v20250116212318 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.45.1-snapshot.v20250116212318 --save-exact

@clerk/elements

npm i @clerk/elements@0.22.10-snapshot.v20250116212318 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.6.13-snapshot.v20250116212318 --save-exact

@clerk/expo-passkeys

npm i @clerk/expo-passkeys@0.1.9-snapshot.v20250116212318 --save-exact

@clerk/express

npm i @clerk/express@1.3.37-snapshot.v20250116212318 --save-exact

@clerk/fastify

npm i @clerk/fastify@2.1.10-snapshot.v20250116212318 --save-exact

@clerk/localizations

npm i @clerk/localizations@3.9.10-snapshot.v20250116212318 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@6.9.13-snapshot.v20250116212318 --save-exact

@clerk/nuxt

npm i @clerk/nuxt@1.0.6-snapshot.v20250116212318 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.22.1-snapshot.v20250116212318 --save-exact

@clerk/react-router

npm i @clerk/react-router@0.1.11-snapshot.v20250116212318 --save-exact

@clerk/remix

npm i @clerk/remix@4.4.12-snapshot.v20250116212318 --save-exact

@clerk/shared

npm i @clerk/shared@2.20.9-snapshot.v20250116212318 --save-exact

@clerk/tanstack-start

npm i @clerk/tanstack-start@0.8.11-snapshot.v20250116212318 --save-exact

@clerk/testing

npm i @clerk/testing@1.4.10-snapshot.v20250116212318 --save-exact

@clerk/themes

npm i @clerk/themes@2.2.8-snapshot.v20250116212318 --save-exact

@clerk/types

npm i @clerk/types@4.41.1-snapshot.v20250116212318 --save-exact

@clerk/ui

npm i @clerk/ui@0.3.11-snapshot.v20250116212318 --save-exact

@clerk/vue

npm i @clerk/vue@1.1.1-snapshot.v20250116212318 --save-exact

const details =
isEnterpriseSSO || isSaml
? {
name: 'SSO',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where this name is surfaced? On the alt of Clerk.Icon?

Also, saml and enterprise_sso don't have predefined icons, since they depend on the enterprise connection type and FAPI doesn't expose this beforehand.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LauraBeatris Yes, it's largely surfaced there. Given the nature of Elements, it's just a default, and devs would know what connections they have available and either slot in their icon to Clerk.Icon or explicitly use their own.

@LauraBeatris LauraBeatris requested a review from a team January 16, 2025 21:44
@LauraBeatris LauraBeatris marked this pull request as ready for review January 16, 2025 21:49
})),
},
'AUTHENTICATE.SAML': {
'AUTHENTICATE.ENTERPRISE_SSO': {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LauraBeatris Any reason that we're updating SAML to ENTERPRISE_SSO on sign-in while simply appending ENTERPRISE_SSO on sign-up?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is wrong - we should keep supporting both, let me fix it here, good catch!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed on 941a14a

Copy link
Member

@tmilewski tmilewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@LauraBeatris LauraBeatris merged commit 7ffc99b into main Jan 16, 2025
29 checks passed
@LauraBeatris LauraBeatris deleted the laura/orgs-480-support-enterprise_sso-strategy-on-clerkelements branch January 16, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants