-
Notifications
You must be signed in to change notification settings - Fork 402
chore(elements,types): Support enterprise_sso strategy
#4916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(elements,types): Support enterprise_sso strategy
#4916
Conversation
🦋 Changeset detectedLatest commit: 941a14a The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
173de41 to
1e1014e
Compare
|
!snapshot |
1e1014e to
413fe0d
Compare
413fe0d to
7cc0576
Compare
|
Hey @LauraBeatris - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/astro@2.1.10-snapshot.v20250116212318 --save-exact
npm i @clerk/backend@1.23.2-snapshot.v20250116212318 --save-exact
npm i @clerk/chrome-extension@2.1.14-snapshot.v20250116212318 --save-exact
npm i @clerk/clerk-js@5.45.1-snapshot.v20250116212318 --save-exact
npm i @clerk/elements@0.22.10-snapshot.v20250116212318 --save-exact
npm i @clerk/clerk-expo@2.6.13-snapshot.v20250116212318 --save-exact
npm i @clerk/expo-passkeys@0.1.9-snapshot.v20250116212318 --save-exact
npm i @clerk/express@1.3.37-snapshot.v20250116212318 --save-exact
npm i @clerk/fastify@2.1.10-snapshot.v20250116212318 --save-exact
npm i @clerk/localizations@3.9.10-snapshot.v20250116212318 --save-exact
npm i @clerk/nextjs@6.9.13-snapshot.v20250116212318 --save-exact
npm i @clerk/nuxt@1.0.6-snapshot.v20250116212318 --save-exact
npm i @clerk/clerk-react@5.22.1-snapshot.v20250116212318 --save-exact
npm i @clerk/react-router@0.1.11-snapshot.v20250116212318 --save-exact
npm i @clerk/remix@4.4.12-snapshot.v20250116212318 --save-exact
npm i @clerk/shared@2.20.9-snapshot.v20250116212318 --save-exact
npm i @clerk/tanstack-start@0.8.11-snapshot.v20250116212318 --save-exact
npm i @clerk/testing@1.4.10-snapshot.v20250116212318 --save-exact
npm i @clerk/themes@2.2.8-snapshot.v20250116212318 --save-exact
npm i @clerk/types@4.41.1-snapshot.v20250116212318 --save-exact
npm i @clerk/ui@0.3.11-snapshot.v20250116212318 --save-exact
npm i @clerk/vue@1.1.1-snapshot.v20250116212318 --save-exact |
| const details = | ||
| isEnterpriseSSO || isSaml | ||
| ? { | ||
| name: 'SSO', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where this name is surfaced? On the alt of Clerk.Icon?
Also, saml and enterprise_sso don't have predefined icons, since they depend on the enterprise connection type and FAPI doesn't expose this beforehand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LauraBeatris Yes, it's largely surfaced there. Given the nature of Elements, it's just a default, and devs would know what connections they have available and either slot in their icon to Clerk.Icon or explicitly use their own.
| })), | ||
| }, | ||
| 'AUTHENTICATE.SAML': { | ||
| 'AUTHENTICATE.ENTERPRISE_SSO': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LauraBeatris Any reason that we're updating SAML to ENTERPRISE_SSO on sign-in while simply appending ENTERPRISE_SSO on sign-up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this is wrong - we should keep supporting both, let me fix it here, good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed on 941a14a
tmilewski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
Description
Allows to use
enterprise_ssofor custom flows with@clerk/elementsCleanShot.2025-01-16.at.18.42.48.mp4
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change