fix(nextjs): [Keyless] Prevent successful build when keys are not explicitly set #4932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5cd3101 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tmilewski
approved these changes
Jan 17, 2025
brkalow
approved these changes
Jan 17, 2025
panteliselef
deleted the
elef/actls-58-prevent-successful-build-when-keys-are-not-explicitly-set
branch
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous
canUseKeyless__clientdid not depend onprocess.env.NODE_ENV, which duringpnpm buildwould caseClientClerkProviderto renderLazyCreateKeylessApplicationwhich then "bypasses" any error related to missing PK.The above was handled gracefully, as clerk-js would simply not be attempted to load. But this PR brings back the intended behaviour.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change