chore(clerk-js): Refactor fapiClient to not rely on Clerk instance #4947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 24d98ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brkalow
commented
Jan 20, 2025
Comment on lines
+7
to
+11
| globals: { | ||
| __PKG_NAME__: '@clerk/clerk-js', | ||
| __PKG_VERSION__: 'test', | ||
| BUILD_ENABLE_NEW_COMPONENTS: '', | ||
| }, |
Member
Author
There was a problem hiding this comment.
It felt more expected to define the global variables here. Moved and added values for the __PKG_ vars.
brkalow
commented
Jan 20, 2025
LekoArts
approved these changes
Jan 21, 2025
| globals: { | ||
| __PKG_NAME__: '@clerk/clerk-js', | ||
| __PKG_VERSION__: 'test', | ||
| BUILD_ENABLE_NEW_COMPONENTS: '', |
Contributor
There was a problem hiding this comment.
I guess since you removed that code in another PR we can remove that global?
|
|
||
| if (clerkInstance.instanceType === 'development' && clerkInstance.isSatellite) { | ||
| searchParams.append('__domain', clerkInstance.domain); | ||
| // if (clerkInstance.instanceType === 'development' && clerkInstance.isSatellite) { |
9 tasks
brkalow
pushed a commit
that referenced
this pull request
Jan 21, 2025
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors
createFapiClient()to not rely on an instance ofClerk(). Instead, accept an explicit options object. This should make this method more portable in the future. If we want to, for example, expose a standalone FAPI client.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change