Skip to content

Conversation

@brkalow
Copy link
Member

@brkalow brkalow commented Jan 20, 2025

Description

Removing the "new" UI components rendering flow. We're not using it for now 😢. If we want it for reference for future work, we can look back in git history.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@brkalow brkalow requested a review from a team January 20, 2025 21:29
@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2025

🦋 Changeset detected

Latest commit: 58213ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 9:45pm

@brkalow brkalow changed the title chore(clerk-js): remove new UI renderer chore(clerk-js): Remove new UI renderer Jan 20, 2025
@panteliselef
Copy link
Member

@brkalow do we expect a decrease on the clerk.browser chunk ? checking if bundlwatch config needs an update.

@brkalow brkalow enabled auto-merge (squash) January 20, 2025 22:39
@brkalow brkalow merged commit 00148b8 into main Jan 20, 2025
29 checks passed
@brkalow brkalow deleted the brk.chore/remove-new-ui-render branch January 20, 2025 22:40
@brkalow
Copy link
Member Author

brkalow commented Jan 20, 2025

@panteliselef good question, I'll check.

panteliselef added a commit that referenced this pull request Feb 13, 2025
We don't need this dependency since #4950 got merged.
panteliselef added a commit that referenced this pull request Feb 13, 2025
We don't need this dependency since #4950 got merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants