-
Notifications
You must be signed in to change notification settings - Fork 404
Update nl-NL.ts #4970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nl-NL.ts #4970
Conversation
🦋 Changeset detectedLatest commit: 7b6397f The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tmilewski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @FiremanPete, thanks for the contribution! I made one small call-out around the waitlist copy. Happy to push this through, once that's up-to-date.
Thanks again!
| actionLink__use_phone: 'Gebruik telefoon', | ||
| actionLink__use_username: 'Gebruik gebruikersnaam', | ||
| actionText: 'Geen account?', | ||
| actionText__join_waitlist: 'Nog geen account? Meld je aan voor de wachtlijst.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave the call-out to the waitlist here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tmilewski, Thanks for the quick feedback!
The callout in the waitlist component clashes with the actual link
So its callout and then same callout but clickable, that's why I edited it out.
Don't suppose there is any way to have the element flex more so the text always fits?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FiremanPete Ah, I see. Happy to merge another PR, with just that change.
…NL.ts Fixed some repeated text in waitlist component translation.
Co-authored-by: Tom Milewski <me@tm.codes>

Update to the dutch localization.
Only string changes of existing code.