Skip to content

Conversation

@FiremanPete
Copy link
Contributor

Update to the dutch localization.
Only string changes of existing code.

@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2025

🦋 Changeset detected

Latest commit: 7b6397f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/ui Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 4:36pm

Copy link
Member

@tmilewski tmilewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @FiremanPete, thanks for the contribution! I made one small call-out around the waitlist copy. Happy to push this through, once that's up-to-date.

Thanks again!

actionLink__use_phone: 'Gebruik telefoon',
actionLink__use_username: 'Gebruik gebruikersnaam',
actionText: 'Geen account?',
actionText__join_waitlist: 'Nog geen account? Meld je aan voor de wachtlijst.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave the call-out to the waitlist here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tmilewski, Thanks for the quick feedback!

The callout in the waitlist component clashes with the actual link
So its callout and then same callout but clickable, that's why I edited it out.

Don't suppose there is any way to have the element flex more so the text always fits?

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FiremanPete Ah, I see. Happy to merge another PR, with just that change.

@tmilewski tmilewski self-assigned this Jan 22, 2025
@tmilewski tmilewski merged commit b72ce86 into clerk:main Jan 22, 2025
8 of 24 checks passed
FiremanPete added a commit to FiremanPete/javascript that referenced this pull request Jan 22, 2025
…NL.ts

Fixed some repeated text in waitlist component translation.
tmilewski added a commit that referenced this pull request Jan 22, 2025
wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
Co-authored-by: Tom Milewski <me@tm.codes>
wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants