Skip to content

Conversation

@tmilewski
Copy link
Member

@tmilewski tmilewski commented Jan 22, 2025

Description

Re-adds handleValueOrFn to @clerk/shared subpaths with a deprecation warning.

Fixes ECO-321

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@tmilewski tmilewski requested review from a team January 22, 2025 16:05
@tmilewski tmilewski self-assigned this Jan 22, 2025
@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2025

🦋 Changeset detected

Latest commit: 5d18d72

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@clerk/shared Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/chrome-extension Patch
@clerk/clerk-js Patch
@clerk/elements Patch
@clerk/expo-passkeys Patch
@clerk/clerk-expo Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/tanstack-start Patch
@clerk/testing Patch
@clerk/ui Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 4:55pm

@tmilewski

This comment was marked as outdated.

@clerk-cookie

This comment was marked as outdated.

Copy link
Member

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be a breaking change

@tmilewski
Copy link
Member Author

tmilewski commented Jan 22, 2025

Seems to be a breaking change

@panteliselef @jacekradko Re-added with a deprecation warning instead.

@tmilewski
Copy link
Member Author

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @tmilewski - the snapshot version command generated the following package versions:

Package Version
@clerk/astro 2.1.14-snapshot.v20250122165556
@clerk/backend 1.23.6-snapshot.v20250122165556
@clerk/chrome-extension 2.1.18-snapshot.v20250122165556
@clerk/clerk-js 5.48.0-snapshot.v20250122165556
@clerk/elements 0.22.14-snapshot.v20250122165556
@clerk/clerk-expo 2.6.17-snapshot.v20250122165556
@clerk/expo-passkeys 0.1.13-snapshot.v20250122165556
@clerk/express 1.3.41-snapshot.v20250122165556
@clerk/fastify 2.1.14-snapshot.v20250122165556
@clerk/nextjs 6.10.1-snapshot.v20250122165556
@clerk/nuxt 1.0.10-snapshot.v20250122165556
@clerk/clerk-react 5.22.5-snapshot.v20250122165556
@clerk/react-router 1.0.0-snapshot.v20250122165556
@clerk/remix 4.4.16-snapshot.v20250122165556
@clerk/shared 2.20.13-snapshot.v20250122165556
@clerk/tanstack-start 0.8.15-snapshot.v20250122165556
@clerk/testing 1.4.14-snapshot.v20250122165556
@clerk/ui 0.3.15-snapshot.v20250122165556
@clerk/vue 1.1.5-snapshot.v20250122165556

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@2.1.14-snapshot.v20250122165556 --save-exact

@clerk/backend

npm i @clerk/backend@1.23.6-snapshot.v20250122165556 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@2.1.18-snapshot.v20250122165556 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.48.0-snapshot.v20250122165556 --save-exact

@clerk/elements

npm i @clerk/elements@0.22.14-snapshot.v20250122165556 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.6.17-snapshot.v20250122165556 --save-exact

@clerk/expo-passkeys

npm i @clerk/expo-passkeys@0.1.13-snapshot.v20250122165556 --save-exact

@clerk/express

npm i @clerk/express@1.3.41-snapshot.v20250122165556 --save-exact

@clerk/fastify

npm i @clerk/fastify@2.1.14-snapshot.v20250122165556 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@6.10.1-snapshot.v20250122165556 --save-exact

@clerk/nuxt

npm i @clerk/nuxt@1.0.10-snapshot.v20250122165556 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.22.5-snapshot.v20250122165556 --save-exact

@clerk/react-router

npm i @clerk/react-router@1.0.0-snapshot.v20250122165556 --save-exact

@clerk/remix

npm i @clerk/remix@4.4.16-snapshot.v20250122165556 --save-exact

@clerk/shared

npm i @clerk/shared@2.20.13-snapshot.v20250122165556 --save-exact

@clerk/tanstack-start

npm i @clerk/tanstack-start@0.8.15-snapshot.v20250122165556 --save-exact

@clerk/testing

npm i @clerk/testing@1.4.14-snapshot.v20250122165556 --save-exact

@clerk/ui

npm i @clerk/ui@0.3.15-snapshot.v20250122165556 --save-exact

@clerk/vue

npm i @clerk/vue@1.1.5-snapshot.v20250122165556 --save-exact

@tmilewski tmilewski merged commit f87ede8 into main Jan 22, 2025
31 checks passed
@tmilewski tmilewski deleted the tm/handleValueOrFn branch January 22, 2025 17:05
@LekoArts LekoArts mentioned this pull request Jan 23, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants