fix(clerk-js): Always pass domain to createFapiClient() #4974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8af2542 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alexcarpenter
approved these changes
Jan 22, 2025
tmilewski
approved these changes
Jan 22, 2025
panteliselef
approved these changes
Jan 22, 2025
| frontendApi: this.frontendApi, | ||
| // this.instanceType is assigned above | ||
| instanceType: this.instanceType as InstanceType, | ||
| isSatellite: this.isSatellite, |
Member
There was a problem hiding this comment.
Was this missing and that's why we had issues, or also domain being undefined was part of the reason ?
Member
Author
There was a problem hiding this comment.
domain being passed as undefined was the main reason. I missed that it was used unconditionally when initializing the client.
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure
createFapiClient()always receives a domain so we can decide if we should be using it or not.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change