Skip to content

fix(shared): Catch atob error #4991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

fix(shared): Catch atob error #4991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e4c446e
fix(shared/keys) catch atob error
Wolfleader101 Jan 24, 2025
8a44b82
changeset updated
Wolfleader101 Jan 24, 2025
e56d9c0
Merge branch 'main' into fix/atob-error
jacekradko Jan 25, 2025
ec57cf1
Merge branch 'main' into fix/atob-error
jacekradko Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tender-bears-design.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/shared': patch
---

isPublishableKey(key) catches atob error
12 changes: 8 additions & 4 deletions packages/shared/src/keys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,17 @@ export function parsePublishableKey(
}

export function isPublishableKey(key: string) {
key = key || '';
try {
key = key || '';

const hasValidPrefix = key.startsWith(PUBLISHABLE_KEY_LIVE_PREFIX) || key.startsWith(PUBLISHABLE_KEY_TEST_PREFIX);
const hasValidPrefix = key.startsWith(PUBLISHABLE_KEY_LIVE_PREFIX) || key.startsWith(PUBLISHABLE_KEY_TEST_PREFIX);

const hasValidFrontendApiPostfix = isomorphicAtob(key.split('_')[2] || '').endsWith('$');
const hasValidFrontendApiPostfix = isomorphicAtob(key.split('_')[2] || '').endsWith('$');

return hasValidPrefix && hasValidFrontendApiPostfix;
return hasValidPrefix && hasValidFrontendApiPostfix;
} catch {
return false;
}
}

export function createDevOrStagingUrlCache() {
Expand Down
Loading