Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/early-apples-return.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Opt out of combined flow when sign up mode is restricted.
8 changes: 8 additions & 0 deletions integration/presets/envs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,13 @@ const withSignInOrUpEmailLinksFlow = withEmailLinks
.setId('withSignInOrUpEmailLinksFlow')
.setEnvVariable('public', 'CLERK_SIGN_UP_URL', undefined);

const withSignInOrUpwithRestrictedModeFlow = withEmailCodes
.clone()
.setId('withSignInOrUpwithRestrictedModeFlow')
.setEnvVariable('private', 'CLERK_SECRET_KEY', instanceKeys.get('with-restricted-mode').sk)
.setEnvVariable('public', 'CLERK_PUBLISHABLE_KEY', instanceKeys.get('with-restricted-mode').pk)
.setEnvVariable('public', 'CLERK_SIGN_UP_URL', undefined);

export const envs = {
base,
withEmailCodes,
Expand All @@ -141,4 +148,5 @@ export const envs = {
withWaitlistdMode,
withSignInOrUpFlow,
withSignInOrUpEmailLinksFlow,
withSignInOrUpwithRestrictedModeFlow,
} as const;
37 changes: 37 additions & 0 deletions integration/tests/sign-in-or-up-restricted-mode.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
import { expect, test } from '@playwright/test';

import type { Application } from '../models/application';
import { appConfigs } from '../presets';
import type { FakeUser } from '../testUtils';
import { createTestUtils } from '../testUtils';

test.describe('sign-in-or-up restricted mode @nextjs', () => {
test.describe.configure({ mode: 'serial' });
let app: Application;
let fakeUser: FakeUser;

test.beforeAll(async () => {
app = await appConfigs.next.appRouter.clone().commit();
await app.setup();
await app.withEnv(appConfigs.envs.withSignInOrUpwithRestrictedModeFlow);
await app.dev();

const m = createTestUtils({ app });
fakeUser = m.services.users.createFakeUser();
});

test.afterAll(async () => {
await fakeUser.deleteIfExists();
await app.teardown();
});

test('It does not allow sign-in-or-up flow', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });
await u.po.signIn.goTo();
await u.po.signIn.waitForMounted();
await expect(u.page.getByText(/continue to/i)).toBeHidden();
await u.po.signIn.getIdentifierInput().fill(fakeUser.email);
await u.po.signIn.continue();
await expect(u.page.getByText(/no account found with this identifier/i)).toBeVisible();
});
});
6 changes: 4 additions & 2 deletions packages/clerk-js/src/ui/contexts/components/SignIn.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,9 @@ export const SignInContext = createContext<SignInCtx | null>(null);
export const useSignInContext = (): SignInContextType => {
const context = useContext(SignInContext);
const { navigate } = useRouter();
const { displayConfig } = useEnvironment();
const { displayConfig, userSettings } = useEnvironment();
const { queryParams, queryString } = useRouter();
const signUpMode = userSettings.signUp.mode;
const options = useOptions();
const clerk = useClerk();

Expand All @@ -43,7 +44,8 @@ export const useSignInContext = (): SignInContextType => {
}

const isCombinedFlow =
Boolean(!options.signUpUrl && options.signInUrl && !isAbsoluteUrl(options.signInUrl)) ||
(signUpMode !== 'restricted' &&
Boolean(!options.signUpUrl && options.signInUrl && !isAbsoluteUrl(options.signInUrl))) ||
context.withSignUp ||
false;

Expand Down
10 changes: 8 additions & 2 deletions packages/clerk-js/src/ui/contexts/components/SignUp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,17 @@ export const SignUpContext = createContext<SignUpCtx | null>(null);
export const useSignUpContext = (): SignUpContextType => {
const context = useContext(SignUpContext);
const { navigate } = useRouter();
const { displayConfig } = useEnvironment();
const { displayConfig, userSettings } = useEnvironment();
const { queryParams, queryString } = useRouter();
const signUpMode = userSettings.signUp.mode;
const options = useOptions();
const clerk = useClerk();
const isCombinedFlow = Boolean(!options.signUpUrl && options.signInUrl && !isAbsoluteUrl(options.signInUrl));
const isCombinedFlow =
(signUpMode !== 'restricted' &&
Boolean(
!options.signUpUrl && options.signInUrl && !isAbsoluteUrl(options.signInUrl) && signUpMode === 'public',
)) ||
false;

const initialValuesFromQueryParams = useMemo(
() => getInitialValuesFromQueryParams(queryString, SIGN_UP_INITIAL_VALUE_KEYS),
Expand Down