Skip to content

chore(repo): Disallow non-null assertions #5038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jacekradko merged 14 commits into from
Mar 24, 2025
Merged

chore(repo): Disallow non-null assertions #5038

jacekradko merged 14 commits into from
Mar 24, 2025

Conversation

@jacekradko
Copy link
Member

@jacekradko jacekradko commented Jan 29, 2025 •
edited
Loading

Description

Making the @typescript-eslint/no-non-null-assertion an error. Disabled all existing violations inline so they can be addressed over time.

Fixes: SDKI-953

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 6f06c14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 29, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 1:21am

@jacekradko jacekradko changed the title chore(repo): disallow non-null assertions chore(repo): Disallow non-null assertions Jan 29, 2025
@clerk-cookie
Copy link
Collaborator

clerk-cookie commented Mar 21, 2025

Hello 👋

We currently close PRs after 60 days of inactivity. It's been 50 days since the last update here. If we missed this PR, please reply here. Otherwise, we'll close this PR in 10 days.

Thanks for being a part of the Clerk community! 🙏

@jacekradko jacekradko removed the Stale label Mar 21, 2025
@jacekradko jacekradko marked this pull request as ready for review March 21, 2025 21:15
dstaley
dstaley reviewed Mar 21, 2025
View reviewed changes
tmilewski
tmilewski reviewed Mar 22, 2025
View reviewed changes
Copy link
Member

@tmilewski tmilewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks good! I'm just also a little concerned about the addition of the --quiet flag.

@jacekradko
Copy link
Member Author

jacekradko commented Mar 24, 2025

@dstaley @tmilewski Removed the --quiet flag

@tmilewski
Copy link
Member

tmilewski commented Mar 24, 2025

@dstaley @tmilewski Removed the --quiet flag

Thanks, approved!

@jacekradko jacekradko merged commit d1f6a56 into main Mar 24, 2025
30 checks passed
@jacekradko jacekradko deleted the chore/error-on-non-null-assertions branch March 24, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dstaley dstaley dstaley left review comments

@tmilewski tmilewski tmilewski approved these changes

Assignees

No one assigned

Labels

astro backend clerk-js elements expo nextjs react vue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jacekradko @clerk-cookie @tmilewski @dstaley