fix(nextjs): Fix infinite redirect loop when page does not exist #5073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 4c83ad6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dstaley
approved these changes
Feb 3, 2025
| const detectedMiddelware = detectClerkMiddleware(request); | ||
|
|
||
| /** | ||
| * Prevents infinite redirects in when the `returnUrl` will result to a 404 (not-found) page. |
There was a problem hiding this comment.
Suggested change
| * Prevents infinite redirects in when the `returnUrl` will result to a 404 (not-found) page. | |
| * Prevents infinite redirects when the `returnUrl` will result to a 404 (not-found) page. |
brkalow
requested changes
Feb 3, 2025
…n page does not exist
panteliselef
deleted the
elef/actls-81-fix-infinite-redirect-when-visiting-not-found
branch
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On keyless avoid infinite redirect loop when page does not exist and application is attempting to sync state with middleware.
Before
Screen.Recording.2025-02-03.at.6.04.01.PM.mov
After
Screen.Recording.2025-02-03.at.6.02.37.PM.mov
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change