-
Notifications
You must be signed in to change notification settings - Fork 402
feat(astro): Add support for type-safe environment variables #5104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e78dded
feat(astro): Add type safe env vars support
wobsoriano 9f23211
chore: update changeset
wobsoriano f5323a0
chore: run dedupe
wobsoriano bee9adb
Update packages/astro/src/integration/create-integration.ts
wobsoriano d8c10fc
Update .changeset/chilly-suns-beg.md
wobsoriano 07c3d9d
chore(astro): Set default value to true
wobsoriano a38993f
chore(astro): Inform about validating secrets
wobsoriano c8b2b55
chore(astro): Set default env schema option value to false
wobsoriano d54605b
chore(astro): Add changeset
wobsoriano d25235c
chore(astro): Commit suggestion to changeset
wobsoriano 4e625e2
chore: Pin latest version of astro and update tsconfig
wobsoriano 4e1abb5
chore: enable feature by default
wobsoriano 6753d44
chore: remove extra changeset
wobsoriano 8f9508b
chore: update changeset
wobsoriano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| --- | ||
| '@clerk/astro': minor | ||
| --- | ||
|
|
||
| Add support for type-safe environment variables using the [`astro:env` API](https://docs.astro.build/en/reference/configuration-reference/#env). | ||
|
|
||
| The integration now provides a type-safe schema for all Clerk environment variables by default. You can use the environment variables like so: | ||
|
|
||
| ```js | ||
| import { PUBLIC_CLERK_PUBLISHABLE_KEY } from "astro:env/client" | ||
| import { CLERK_SECRET_KEY } from "astro:env/server" | ||
| ``` | ||
|
|
||
| To override this behavior, you can disable the feature by setting `enableEnvSchema` to `false`: | ||
|
|
||
| ```js | ||
| export default defineConfig({ | ||
| integrations: [clerk({ enableEnvSchema: false })], | ||
| }) | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update this to properly resolve imports from packages that use export maps (like
astro/config)