-
Notifications
You must be signed in to change notification settings - Fork 402
feat(clerk-js,shared,nextjs,react-router,clerk-react,remix): Introduce EmailLinkErrorCodeStatus
#5142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clerk-js,shared,nextjs,react-router,clerk-react,remix): Introduce EmailLinkErrorCodeStatus
#5142
Conversation
🦋 Changeset detectedLatest commit: afe8949 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but this is technically a breaking change in the most technical sense given that we're narrowing EmailLinkErrorCode from Record<string, string> to a more restrictive type. I think this is probably fine, but there's technically user code that could break as a result of this change.
EmailLinkErrorCode as constEmailLinkErrorCodeStatus and deprecate EmailLinkErrorCode
EmailLinkErrorCodeStatus and deprecate EmailLinkErrorCodeEmailLinkErrorCodeStatus and deprecate EmailLinkErrorCode
EmailLinkErrorCodeStatus and deprecate EmailLinkErrorCodeEmailLinkErrorCodeStatus
EmailLinkErrorCodeStatusEmailLinkErrorCodeStatus
| isKnownError, | ||
| isMetamaskError, | ||
| EmailLinkErrorCode, | ||
| EmailLinkErrorCodeStatus, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to re-export it from src/errors.ts
|
|
||
| ```diff | ||
| - import { EmailLinkErrorCode } from '@clerk/nextjs/errors' | ||
| + import { EmailLinkErrorCodeStatus } from '@clerk/nextjs/errors' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to re-export EmailLinkErrorCodeStatus from src/errors.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
Description
EmailLinkErrorCodeas deprecatedEmailLinkErrorCodeStatusResolves SDK-2055
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change