fix(nextjs): Update clerkMiddleware request callback to accept an async function
#5147
Conversation
🦋 Changeset detectedLatest commit: c8bf4b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
itsjxck
changed the title
ClerkMiddlewareOptionsCallback
|
Hey @itsjxck, thanks for the contribution! The ability to provide Our docs indeed highlight the use case of fetching options from an external store, so that was missing case from our side! I'll just run more tests on my side here and will keep you updated |
|
You absolute ⭐ thank you @LauraBeatris ! |
LauraBeatris
changed the title
ClerkMiddlewareOptionsCallbackclerkMiddleware request callback to accept an async function
LauraBeatris
force-pushed
the
fix/accept-async-clerk-middleware-options-callback
branch
from
e140d8b to
ce8f6ef
Compare
LauraBeatris
force-pushed
the
fix/accept-async-clerk-middleware-options-callback
branch
from
ce8f6ef to
c8bf4b8
Compare
|
Hey @itsjxck, unfortunately we currently have a CI issue regarding GitHub secrets in which it doesn't get shared with external contributors, and the integration tests are failing here In order to unblock you, I've extracted the changes into a separate PR: #5154 I'll close this PR, and thanks again for the contribution! |
3 participants
Description
Update
ClerkMiddlewareOptionsCallbackto accept an async function for the use case where you need to go and fetch the options from an external store. I'm unsure whether this is technically a bug or a feature, because the docs imply that it's supposed to work anyway.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change