Skip to content

Conversation

@alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented Feb 13, 2025

Description

I noticed in dashboard that the input placeholder color was super light, and noticed we don't define the actual placeholder color within the input primitive. This PR sets a default color like we do in TagInput

color: t.colors.$colorTextSecondary,

BEFORE AFTER
Screenshot 2025-02-19 at 2 03 49 PM Screenshot 2025-02-19 at 2 04 13 PM

Users can still override via appearance prop as needed.

appearance: {
  elements: {
    input: {
      '&::placeholder': {
        color: '#b00b00',
      },
    },
  },
},

Resolves SDKI-891

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2025

🦋 Changeset detected

Latest commit: 14552ba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 7:08pm

@alexcarpenter alexcarpenter merged commit 3345667 into main Feb 20, 2025
29 checks passed
@alexcarpenter alexcarpenter deleted the alexcarpenter/input-primitive-placeholder-color branch February 20, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants