Skip to content

Conversation

@brkalow
Copy link
Member

@brkalow brkalow commented Feb 14, 2025

Description

Removes setActive() call from signOut() implementation, fixing a number of bugs related to sign out.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2025

🦋 Changeset detected

Latest commit: 5a0ecb7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/clerk-js Patch
@clerk/nextjs Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 0:29am

@brkalow brkalow requested a review from a team February 18, 2025 23:31
@brkalow brkalow marked this pull request as ready for review February 18, 2025 23:31
@panteliselef
Copy link
Member

!snapshot

1 similar comment
@panteliselef
Copy link
Member

!snapshot

@panteliselef
Copy link
Member

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @panteliselef - the snapshot version command generated the following package versions:

Package Version
@clerk/chrome-extension 2.2.12-snapshot.v20250228120517
@clerk/clerk-js 5.54.1-snapshot.v20250228120517
@clerk/dev-cli 0.0.11-snapshot.v20250228120517
@clerk/clerk-expo 2.8.1-snapshot.v20250228120517

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@2.2.12-snapshot.v20250228120517 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.54.1-snapshot.v20250228120517 --save-exact

@clerk/dev-cli

npm i @clerk/dev-cli@0.0.11-snapshot.v20250228120517 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.8.1-snapshot.v20250228120517 --save-exact

@panteliselef
Copy link
Member

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @panteliselef - the snapshot version command generated the following package versions:

Package Version
@clerk/chrome-extension 2.2.13-snapshot.v20250228122946
@clerk/clerk-js 5.54.2-snapshot.v20250228122946
@clerk/clerk-expo 2.8.2-snapshot.v20250228122946
@clerk/nextjs 6.12.2-snapshot.v20250228122946

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@2.2.13-snapshot.v20250228122946 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.54.2-snapshot.v20250228122946 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.8.2-snapshot.v20250228122946 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@6.12.2-snapshot.v20250228122946 --save-exact

@brkalow brkalow requested a review from a team February 28, 2025 16:11
Copy link
Member

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢🚢

@brkalow brkalow merged commit 6f20f76 into main Feb 28, 2025
26 of 27 checks passed
@brkalow brkalow deleted the brk.feat/sign-out-no-set-active branch February 28, 2025 18:57
jacekradko pushed a commit that referenced this pull request Mar 5, 2025
Co-authored-by: panteliselef <panteliselef@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants